From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Adrian Hunter <adrian.hunter@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties
Date: Sat, 16 May 2020 18:43:14 +0300 [thread overview]
Message-ID: <20200516154314.14769-1-digetx@gmail.com> (raw)
Several people asked me about the MMC warnings in the KMSG log and
I had to tell to ignore them because these warning are irrelevant to
pre-Tegra210 SoCs. It should be up to a board's device-tree writer to
properly describe all the necessary properties. Secondly, eventually all
device-tree bindings will be converted to YAML, which allows to validate
board DT files, giving a warning about missing properties. Hence let's
remove the noisy warnings to stop the confusion.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/mmc/host/sdhci-tegra.c | 28 ++++------------------------
1 file changed, 4 insertions(+), 24 deletions(-)
diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
index 3e2c5101291d..83867629013d 100644
--- a/drivers/mmc/host/sdhci-tegra.c
+++ b/drivers/mmc/host/sdhci-tegra.c
@@ -607,46 +607,26 @@ static void tegra_sdhci_parse_pad_autocal_dt(struct sdhci_host *host)
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-up-offset-3v3-timeout",
&autocal->pull_up_3v3_timeout);
- if (err) {
- if (!IS_ERR(tegra_host->pinctrl_state_3v3) &&
- (tegra_host->pinctrl_state_3v3_drv == NULL))
- pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n",
- mmc_hostname(host->mmc));
+ if (err)
autocal->pull_up_3v3_timeout = 0;
- }
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-down-offset-3v3-timeout",
&autocal->pull_down_3v3_timeout);
- if (err) {
- if (!IS_ERR(tegra_host->pinctrl_state_3v3) &&
- (tegra_host->pinctrl_state_3v3_drv == NULL))
- pr_warn("%s: Missing autocal timeout 3v3-pad drvs\n",
- mmc_hostname(host->mmc));
+ if (err)
autocal->pull_down_3v3_timeout = 0;
- }
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-up-offset-1v8-timeout",
&autocal->pull_up_1v8_timeout);
- if (err) {
- if (!IS_ERR(tegra_host->pinctrl_state_1v8) &&
- (tegra_host->pinctrl_state_1v8_drv == NULL))
- pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n",
- mmc_hostname(host->mmc));
+ if (err)
autocal->pull_up_1v8_timeout = 0;
- }
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-down-offset-1v8-timeout",
&autocal->pull_down_1v8_timeout);
- if (err) {
- if (!IS_ERR(tegra_host->pinctrl_state_1v8) &&
- (tegra_host->pinctrl_state_1v8_drv == NULL))
- pr_warn("%s: Missing autocal timeout 1v8-pad drvs\n",
- mmc_hostname(host->mmc));
+ if (err)
autocal->pull_down_1v8_timeout = 0;
- }
err = device_property_read_u32(host->mmc->parent,
"nvidia,pad-autocal-pull-up-offset-sdr104",
--
2.26.0
next reply other threads:[~2020-05-16 15:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-16 15:43 Dmitry Osipenko [this message]
2020-05-19 7:28 ` [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties Ulf Hansson
2020-05-19 14:05 ` Dmitry Osipenko
2020-05-19 15:29 ` Ulf Hansson
2020-05-19 16:24 ` Thierry Reding
2020-05-19 16:33 ` Dmitry Osipenko
2020-05-19 18:34 ` Sowjanya Komatineni
2020-05-19 18:41 ` Sowjanya Komatineni
2020-05-19 19:07 ` Sowjanya Komatineni
2020-05-19 20:44 ` Sowjanya Komatineni
2020-05-20 2:00 ` Dmitry Osipenko
2020-05-20 11:26 ` Ulf Hansson
2020-05-20 16:09 ` Sowjanya Komatineni
2020-05-22 12:13 ` Thierry Reding
2020-05-22 12:18 ` Dmitry Osipenko
2020-05-22 12:34 ` Thierry Reding
2020-05-22 15:22 ` Sowjanya Komatineni
2020-05-22 15:26 ` Thierry Reding
2020-05-22 15:57 ` Sowjanya Komatineni
2020-05-25 8:47 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516154314.14769-1-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).