From: "tip-bot2 for Andrew Morton" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
Borislav Petkov <bp@suse.de>, Ingo Molnar <mingo@kernel.org>,
x86 <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: [tip: x86/build] x86/build: Use $(CONFIG_SHELL)
Date: Sun, 17 May 2020 13:08:26 -0000 [thread overview]
Message-ID: <158972090630.17951.4281123342624645094.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200505211932.GE6880@zn.tnic>
The following commit has been merged into the x86/build branch of tip:
Commit-ID: 0be11088b848774ae1f693169fdb9575e0ff06ba
Gitweb: https://git.kernel.org/tip/0be11088b848774ae1f693169fdb9575e0ff06ba
Author: Andrew Morton <akpm@linux-foundation.org>
AuthorDate: Tue, 05 May 2020 14:26:51 -07:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Sun, 17 May 2020 16:01:33 +03:00
x86/build: Use $(CONFIG_SHELL)
When scripts/x86-check-compiler.sh doesn't have the executable bit set:
q:/usr/src/25> make clean
make: execvp: ./scripts/x86-check-compiler.sh: Permission denied
Fix this by using $(CONFIG_SHELL).
This will happen if the user downloads and applies patch-5.7.tar.gz, since
patch(1) doesn't preserve the x bit.
Fixes: 73da86741e7f7 ("x86/build: Check whether the compiler is sane")
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lkml.kernel.org/r/20200505211932.GE6880@zn.tnic
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
arch/x86/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/Makefile b/arch/x86/Makefile
index 38d3eec..9e22791 100644
--- a/arch/x86/Makefile
+++ b/arch/x86/Makefile
@@ -2,7 +2,7 @@
# Unified Makefile for i386 and x86_64
# Check the compiler
-sane_compiler := $(shell $(srctree)/scripts/x86-check-compiler.sh $(CC))
+sane_compiler := $($(CONFIG_SHELL) $(srctree)/scripts/x86-check-compiler.sh $(CC))
$(if $(sane_compiler),$(error $(CC) check failed. Aborting),)
# select defconfig based on actual architecture
prev parent reply other threads:[~2020-05-17 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200505211301.9_zLPwR3D%akpm@linux-foundation.org>
2020-05-05 21:19 ` + arch-x86-makefile-use-config_shell.patch added to -mm tree Borislav Petkov
2020-05-06 7:56 ` [tip: x86/build] x86/build: Use $(CONFIG_SHELL) tip-bot2 for Andrew Morton
2020-05-17 13:08 ` tip-bot2 for Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=158972090630.17951.4281123342624645094.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=bp@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).