From: <yuechao.zhao@advantech.com.cn>
To: <345351830@qq.com>
Cc: <amy.shih@advantech.com.tw>, <oakley.ding@advantech.com.tw>,
<jia.sui@advantech.com.cn>,
Yuechao Zhao <yuechao.zhao@advantech.com.cn>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>, <linux-hwmon@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [v1,1/1 1/2] Check the timeout module parameter is in the min-max range
Date: Wed, 27 May 2020 01:18:38 +0000 [thread overview]
Message-ID: <1590542319-35736-1-git-send-email-yuechao.zhao@advantech.com.cn> (raw)
From: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
Check the return value of 'watchdog_init_timeout()' for checking the
timeout module parameter is in the min-max range.
Signed-off-by: Yuechao Zhao <yuechao.zhao@advantech.com.cn>
---
drivers/hwmon/nct7904.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
index 18c95be..d069d59 100644
--- a/drivers/hwmon/nct7904.c
+++ b/drivers/hwmon/nct7904.c
@@ -1152,7 +1152,10 @@ static int nct7904_probe(struct i2c_client *client,
data->wdt.max_timeout = MAX_TIMEOUT;
data->wdt.parent = &client->dev;
- watchdog_init_timeout(&data->wdt, timeout * 60, &client->dev);
+ ret = watchdog_init_timeout(&data->wdt, timeout * 60, &client->dev);
+ if (ret < 0)
+ return ret;
+
watchdog_set_nowayout(&data->wdt, nowayout);
watchdog_set_drvdata(&data->wdt, data);
--
1.8.3.1
next reply other threads:[~2020-05-27 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 1:18 yuechao.zhao [this message]
2020-05-27 1:18 ` [v1,1/1 2/2] Set the default timeout yuechao.zhao
2020-05-27 1:46 ` Guenter Roeck
2020-05-27 1:42 ` [v1,1/1 1/2] Check the timeout module parameter is in the min-max range Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590542319-35736-1-git-send-email-yuechao.zhao@advantech.com.cn \
--to=yuechao.zhao@advantech.com.cn \
--cc=345351830@qq.com \
--cc=amy.shih@advantech.com.tw \
--cc=jdelvare@suse.com \
--cc=jia.sui@advantech.com.cn \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=oakley.ding@advantech.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).