From: Palmer Dabbelt <palmer@dabbelt.com>
To: linux-riscv@lists.infradead.org
Cc: Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
yash.shah@sifive.com, anup@brainfault.org, bp@suse.de,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-team@android.com, kernel-team@android.com,
Palmer Dabbelt <palmerdabbelt@google.com>
Subject: [PATCH 1/2] soc: sifive: l2 cache: Eliminate an unsigned zero compare warning
Date: Thu, 28 May 2020 15:43:52 -0700 [thread overview]
Message-ID: <20200528224353.32559-1-palmer@dabbelt.com> (raw)
From: Palmer Dabbelt <palmerdabbelt@google.com>
GCC warns about this comparison, which is unnecessary.
Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
drivers/soc/sifive/sifive_l2_cache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/sifive/sifive_l2_cache.c b/drivers/soc/sifive/sifive_l2_cache.c
index d5f266551880..51e198880a8d 100644
--- a/drivers/soc/sifive/sifive_l2_cache.c
+++ b/drivers/soc/sifive/sifive_l2_cache.c
@@ -51,7 +51,7 @@ static ssize_t l2_write(struct file *file, const char __user *data,
if (kstrtouint_from_user(data, count, 0, &val))
return -EINVAL;
- if ((val >= 0 && val < 0xFF) || (val >= 0x10000 && val < 0x100FF))
+ if ((val < 0xFF) || (val >= 0x10000 && val < 0x100FF))
writel(val, l2_base + SIFIVE_L2_ECCINJECTERR);
else
return -EINVAL;
--
2.27.0.rc0.183.gde8f92d652-goog
next reply other threads:[~2020-05-28 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 22:43 Palmer Dabbelt [this message]
2020-05-28 22:43 ` [PATCH 2/2] soc: sifive: l2 cache: Mark l2_get_priv_group as static Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528224353.32559-1-palmer@dabbelt.com \
--to=palmer@dabbelt.com \
--cc=anup@brainfault.org \
--cc=bp@suse.de \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmerdabbelt@google.com \
--cc=paul.walmsley@sifive.com \
--cc=yash.shah@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).