From: Arnd Bergmann <arnd@arndb.de>
To: "Paul E. McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] refperf: work around 64-bit division
Date: Fri, 29 May 2020 22:15:51 +0200 [thread overview]
Message-ID: <20200529201600.493808-1-arnd@arndb.de> (raw)
A 64-bit division was introduced in refperf, breaking compilation
on all 32-bit architectures:
kernel/rcu/refperf.o: in function `main_func':
refperf.c:(.text+0x57c): undefined reference to `__aeabi_uldivmod'
Work it by using div_u64 to mark the expensive operation.
Fixes: bd5b16d6c88d ("refperf: Allow decimal nanoseconds")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
kernel/rcu/refperf.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/refperf.c b/kernel/rcu/refperf.c
index 47df72c492b3..c2366648981d 100644
--- a/kernel/rcu/refperf.c
+++ b/kernel/rcu/refperf.c
@@ -386,7 +386,7 @@ static int main_func(void *arg)
if (torture_must_stop())
goto end;
- result_avg[exp] = 1000 * process_durations(nreaders) / (nreaders * loops);
+ result_avg[exp] = div_u64(1000 * process_durations(nreaders), nreaders * loops);
}
// Print the average of all experiments
@@ -397,9 +397,14 @@ static int main_func(void *arg)
strcat(buf, "Threads\tTime(ns)\n");
for (exp = 0; exp < nruns; exp++) {
+ u64 avg;
+ u32 rem;
+
if (errexit)
break;
- sprintf(buf1, "%d\t%llu.%03d\n", exp + 1, result_avg[exp] / 1000, (int)(result_avg[exp] % 1000));
+
+ avg = div_s64_rem(result_avg[exp], 1000, &rem);
+ sprintf(buf1, "%d\t%llu.%03d\n", exp + 1, avg, rem);
strcat(buf, buf1);
}
--
2.26.2
next reply other threads:[~2020-05-29 20:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 20:15 Arnd Bergmann [this message]
2020-05-29 21:41 ` [PATCH] refperf: work around 64-bit division Paul E. McKenney
2020-05-29 22:12 ` Randy Dunlap
2020-05-30 3:52 ` Nathan Chancellor
2020-05-30 8:01 ` Arnd Bergmann
2020-05-30 12:47 ` Paul E. McKenney
2020-05-31 20:03 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529201600.493808-1-arnd@arndb.de \
--to=arnd@arndb.de \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).