From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v6 11/13] perf record: extend -D,--delay option with -1 value
Date: Mon, 1 Jun 2020 23:18:57 +0300 [thread overview]
Message-ID: <3fb3d8cc-067f-722d-4801-210061cfad8a@linux.intel.com> (raw)
In-Reply-To: <f8e3a714-d9b1-4647-e1d2-9981cbaa83ec@linux.intel.com>
Extend -D,--delay option with -1 to start collection with events
disabled to be enabled later by enable command provided via control
file descriptor.
Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
---
tools/perf/Documentation/perf-record.txt | 5 +++--
tools/perf/builtin-record.c | 12 ++++++++----
tools/perf/builtin-trace.c | 2 +-
tools/perf/util/record.h | 2 +-
4 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/tools/perf/Documentation/perf-record.txt b/tools/perf/Documentation/perf-record.txt
index fa8a5fcd27ab..a84376605805 100644
--- a/tools/perf/Documentation/perf-record.txt
+++ b/tools/perf/Documentation/perf-record.txt
@@ -407,8 +407,9 @@ if combined with -a or -C options.
-D::
--delay=::
-After starting the program, wait msecs before measuring. This is useful to
-filter out the startup phase of the program, which is often very different.
+After starting the program, wait msecs before measuring (-1: start with events
+disabled). This is useful to filter out the startup phase of the program, which
+is often very different.
-I::
--intr-regs::
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index e108d90ae2ed..d0b29a1070a0 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1749,8 +1749,12 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
}
if (opts->initial_delay) {
- usleep(opts->initial_delay * USEC_PER_MSEC);
- evlist__enable(rec->evlist);
+ pr_info(EVLIST_DISABLED_MSG);
+ if (opts->initial_delay > 0) {
+ usleep(opts->initial_delay * USEC_PER_MSEC);
+ evlist__enable(rec->evlist);
+ pr_info(EVLIST_ENABLED_MSG);
+ }
}
trigger_ready(&auxtrace_snapshot_trigger);
@@ -2462,8 +2466,8 @@ static struct option __record_options[] = {
OPT_CALLBACK('G', "cgroup", &record.evlist, "name",
"monitor event in cgroup name only",
parse_cgroups),
- OPT_UINTEGER('D', "delay", &record.opts.initial_delay,
- "ms to wait before starting measurement after program start"),
+ OPT_INTEGER('D', "delay", &record.opts.initial_delay,
+ "ms to wait before starting measurement after program start (-1: start with events disabled)"),
OPT_BOOLEAN(0, "kcore", &record.opts.kcore, "copy /proc/kcore"),
OPT_STRING('u', "uid", &record.opts.target.uid_str, "user",
"user to profile"),
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 4cbb64edc998..290149b1b3b5 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -4813,7 +4813,7 @@ int cmd_trace(int argc, const char **argv)
"per thread proc mmap processing timeout in ms"),
OPT_CALLBACK('G', "cgroup", &trace, "name", "monitor event in cgroup name only",
trace__parse_cgroups),
- OPT_UINTEGER('D', "delay", &trace.opts.initial_delay,
+ OPT_INTEGER('D', "delay", &trace.opts.initial_delay,
"ms to wait before starting measurement after program "
"start"),
OPTS_EVSWITCH(&trace.evswitch),
diff --git a/tools/perf/util/record.h b/tools/perf/util/record.h
index 39d1de4b2a36..da138dcb4d34 100644
--- a/tools/perf/util/record.h
+++ b/tools/perf/util/record.h
@@ -61,7 +61,7 @@ struct record_opts {
const char *auxtrace_snapshot_opts;
const char *auxtrace_sample_opts;
bool sample_transaction;
- unsigned initial_delay;
+ int initial_delay;
bool use_clockid;
clockid_t clockid;
u64 clockid_res_ns;
--
2.24.1
next prev parent reply other threads:[~2020-06-01 20:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 20:01 [PATCH v6 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-01 20:05 ` [PATCH v6 01/13] tools/libperf: introduce notion of static polled file descriptors Alexey Budankov
2020-06-03 11:38 ` Adrian Hunter
2020-06-03 12:01 ` Alexey Budankov
2020-06-03 12:23 ` Adrian Hunter
2020-06-03 12:30 ` Hunter, Adrian
2020-06-03 12:52 ` Alexey Budankov
2020-06-03 15:53 ` Adrian Hunter
2020-06-03 17:00 ` Alexey Budankov
2020-06-01 20:06 ` [PATCH v6 02/13] perf evlist: introduce control " Alexey Budankov
2020-06-01 20:07 ` [PATCH v6 03/13] perf evlist: implement control command handling functions Alexey Budankov
2020-06-01 20:08 ` [PATCH v6 04/13] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-06-01 20:08 ` [PATCH v6 05/13] perf stat: move target check to loop control statement Alexey Budankov
2020-06-01 20:09 ` [PATCH v6 06/13] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-06-01 20:10 ` [PATCH v6 07/13] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-06-01 20:15 ` [PATCH v6 08/13] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-06-01 20:17 ` [PATCH v6 09/13] perf stat: implement control commands handling Alexey Budankov
2020-06-01 20:17 ` [PATCH v6 10/13] perf stat: introduce --ctl-fd[-ack] options Alexey Budankov
2020-06-01 20:18 ` Alexey Budankov [this message]
2020-06-01 20:19 ` [PATCH v6 12/13] perf record: implement control commands handling Alexey Budankov
2020-06-01 20:20 ` [PATCH v6 13/13] perf record: introduce --ctl-fd[-ack] options Alexey Budankov
2020-06-03 12:24 ` Adrian Hunter
2020-06-03 12:52 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fb3d8cc-067f-722d-4801-210061cfad8a@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).