From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v6 13/13] perf record: introduce --ctl-fd[-ack] options
Date: Mon, 1 Jun 2020 23:20:23 +0300 [thread overview]
Message-ID: <fdb10392-15d9-be66-12e7-b1f465737a0e@linux.intel.com> (raw)
In-Reply-To: <f8e3a714-d9b1-4647-e1d2-9981cbaa83ec@linux.intel.com>
Introduce --ctl-fd[-ack] options to pass open file descriptors numbers
from command line. Extend perf-record.txt file with --ctl-fd[-ack]
options description. Document possible usage model introduced by
--ctl-fd[-ack] options by providing example bash shell script.
Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
---
tools/perf/builtin-record.c | 10 ++++++++++
tools/perf/util/record.h | 2 ++
2 files changed, 12 insertions(+)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 0394e068dde8..8494ce964738 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -1749,6 +1749,9 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
perf_evlist__start_workload(rec->evlist);
}
+ if (evlist__initialize_ctlfd(rec->evlist, opts->ctl_fd, opts->ctl_fd_ack))
+ goto out_child;
+
if (opts->initial_delay) {
pr_info(EVLIST_DISABLED_MSG);
if (opts->initial_delay > 0) {
@@ -1895,6 +1898,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
record__synthesize_workload(rec, true);
out_child:
+ evlist__finalize_ctlfd(rec->evlist);
record__mmap_read_all(rec, true);
record__aio_mmap_read_sync(rec);
@@ -2380,6 +2384,8 @@ static struct record record = {
},
.mmap_flush = MMAP_FLUSH_DEFAULT,
.nr_threads_synthesize = 1,
+ .ctl_fd = -1,
+ .ctl_fd_ack = -1,
},
.tool = {
.sample = process_sample_event,
@@ -2581,6 +2587,10 @@ static struct option __record_options[] = {
"libpfm4 event selector. use 'perf list' to list available events",
parse_libpfm_events_option),
#endif
+ OPT_INTEGER(0, "ctl-fd", &record.opts.ctl_fd,
+ "Listen on fd descriptor for command to control measurement ('enable': enable events, 'disable': disable events)"),
+ OPT_INTEGER(0, "ctl-fd-ack", &record.opts.ctl_fd_ack,
+ "Send control command completion ('ack') to fd ack descriptor"),
OPT_END()
};
diff --git a/tools/perf/util/record.h b/tools/perf/util/record.h
index da138dcb4d34..4cb72a478af1 100644
--- a/tools/perf/util/record.h
+++ b/tools/perf/util/record.h
@@ -70,6 +70,8 @@ struct record_opts {
int mmap_flush;
unsigned int comp_level;
unsigned int nr_threads_synthesize;
+ int ctl_fd;
+ int ctl_fd_ack;
};
extern const char * const *record_usage;
--
2.24.1
next prev parent reply other threads:[~2020-06-01 20:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 20:01 [PATCH v6 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-01 20:05 ` [PATCH v6 01/13] tools/libperf: introduce notion of static polled file descriptors Alexey Budankov
2020-06-03 11:38 ` Adrian Hunter
2020-06-03 12:01 ` Alexey Budankov
2020-06-03 12:23 ` Adrian Hunter
2020-06-03 12:30 ` Hunter, Adrian
2020-06-03 12:52 ` Alexey Budankov
2020-06-03 15:53 ` Adrian Hunter
2020-06-03 17:00 ` Alexey Budankov
2020-06-01 20:06 ` [PATCH v6 02/13] perf evlist: introduce control " Alexey Budankov
2020-06-01 20:07 ` [PATCH v6 03/13] perf evlist: implement control command handling functions Alexey Budankov
2020-06-01 20:08 ` [PATCH v6 04/13] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-06-01 20:08 ` [PATCH v6 05/13] perf stat: move target check to loop control statement Alexey Budankov
2020-06-01 20:09 ` [PATCH v6 06/13] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-06-01 20:10 ` [PATCH v6 07/13] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-06-01 20:15 ` [PATCH v6 08/13] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-06-01 20:17 ` [PATCH v6 09/13] perf stat: implement control commands handling Alexey Budankov
2020-06-01 20:17 ` [PATCH v6 10/13] perf stat: introduce --ctl-fd[-ack] options Alexey Budankov
2020-06-01 20:18 ` [PATCH v6 11/13] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-06-01 20:19 ` [PATCH v6 12/13] perf record: implement control commands handling Alexey Budankov
2020-06-01 20:20 ` Alexey Budankov [this message]
2020-06-03 12:24 ` [PATCH v6 13/13] perf record: introduce --ctl-fd[-ack] options Adrian Hunter
2020-06-03 12:52 ` Alexey Budankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdb10392-15d9-be66-12e7-b1f465737a0e@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).