[1/2] kernel/panic.c: Make oops_may_print() return bool
diff mbox series

Message ID 1591103358-32087-1-git-send-email-yangtiezhu@loongson.cn
State In Next
Commit 77c777d9ab7d59359538fe4b631f51cb0b474fb2
Headers show
Series
  • [1/2] kernel/panic.c: Make oops_may_print() return bool
Related show

Commit Message

Tiezhu Yang June 2, 2020, 1:09 p.m. UTC
The return value of oops_may_print() is true or false, so change its type
to reflect that.

Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
 include/linux/kernel.h | 2 +-
 kernel/panic.c         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Kees Cook June 2, 2020, 6:07 p.m. UTC | #1
On Tue, Jun 02, 2020 at 09:09:17PM +0800, Tiezhu Yang wrote:
> The return value of oops_may_print() is true or false, so change its type
> to reflect that.
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

Sure, that looks fine. :)

Reviewed-by: Kees Cook <keescook@chromium.org>

Patch
diff mbox series

diff --git a/include/linux/kernel.h b/include/linux/kernel.h
index 9b7a8d7..69c7fa4 100644
--- a/include/linux/kernel.h
+++ b/include/linux/kernel.h
@@ -322,7 +322,7 @@  void nmi_panic(struct pt_regs *regs, const char *msg);
 extern void oops_enter(void);
 extern void oops_exit(void);
 void print_oops_end_marker(void);
-extern int oops_may_print(void);
+extern bool oops_may_print(void);
 void do_exit(long error_code) __noreturn;
 void complete_and_exit(struct completion *, long) __noreturn;
 
diff --git a/kernel/panic.c b/kernel/panic.c
index b69ee9e..064d80f 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -490,7 +490,7 @@  static void do_oops_enter_exit(void)
  * Return true if the calling CPU is allowed to print oops-related info.
  * This is a bit racy..
  */
-int oops_may_print(void)
+bool oops_may_print(void)
 {
 	return pause_on_oops_flag == 0;
 }