[-next] PCI: uniphier: Fix Kconfig warning
diff mbox series

Message ID 20200602131033.41780-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] PCI: uniphier: Fix Kconfig warning
Related show

Commit Message

YueHaibing June 2, 2020, 1:10 p.m. UTC
WARNING: unmet direct dependencies detected for PCIE_DW_EP
  Depends on [n]: PCI [=y] && PCI_ENDPOINT [=n]
  Selected by [y]:
  - PCIE_UNIPHIER_EP [=y] && PCI [=y] && (ARCH_UNIPHIER || COMPILE_TEST [=y]) && OF [=y] && HAS_IOMEM [=y]

Add missing dependency to fix this.

Fixes: 006564dee825 ("PCI: uniphier: Add Socionext UniPhier Pro5 PCIe endpoint controller driver")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/pci/controller/dwc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Lorenzo Pieralisi June 2, 2020, 2:38 p.m. UTC | #1
On Tue, Jun 02, 2020 at 09:10:33PM +0800, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for PCIE_DW_EP
>   Depends on [n]: PCI [=y] && PCI_ENDPOINT [=n]
>   Selected by [y]:
>   - PCIE_UNIPHIER_EP [=y] && PCI [=y] && (ARCH_UNIPHIER || COMPILE_TEST [=y]) && OF [=y] && HAS_IOMEM [=y]
> 
> Add missing dependency to fix this.
> 
> Fixes: 006564dee825 ("PCI: uniphier: Add Socionext UniPhier Pro5 PCIe endpoint controller driver")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/pci/controller/dwc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Squashed in the commit it is fixing, thanks !

Lorenzo

> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 43a29f7a4501..044a3761c44f 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -293,6 +293,7 @@ config PCIE_UNIPHIER_EP
>  	bool "Socionext UniPhier PCIe endpoint controllers"
>  	depends on ARCH_UNIPHIER || COMPILE_TEST
>  	depends on OF && HAS_IOMEM
> +	depends on PCI_ENDPOINT
>  	select PCIE_DW_EP
>  	help
>  	  Say Y here if you want PCIe endpoint controller support on
> -- 
> 2.17.1
> 
>

Patch
diff mbox series

diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
index 43a29f7a4501..044a3761c44f 100644
--- a/drivers/pci/controller/dwc/Kconfig
+++ b/drivers/pci/controller/dwc/Kconfig
@@ -293,6 +293,7 @@  config PCIE_UNIPHIER_EP
 	bool "Socionext UniPhier PCIe endpoint controllers"
 	depends on ARCH_UNIPHIER || COMPILE_TEST
 	depends on OF && HAS_IOMEM
+	depends on PCI_ENDPOINT
 	select PCIE_DW_EP
 	help
 	  Say Y here if you want PCIe endpoint controller support on