linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sumit Garg <sumit.garg@linaro.org>
To: daniel.thompson@linaro.org
Cc: kgdb-bugreport@lists.sourceforge.net, jason.wessel@windriver.com,
	dianders@chromium.org, pmladek@suse.com,
	sergey.senozhatsky@gmail.com, gregkh@linuxfoundation.org,
	jslaby@suse.com, linux-kernel@vger.kernel.org,
	Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH v5 2/4] kdb: Check status of console prior to invoking handlers
Date: Wed,  3 Jun 2020 12:52:13 +0530	[thread overview]
Message-ID: <1591168935-6382-3-git-send-email-sumit.garg@linaro.org> (raw)
In-Reply-To: <1591168935-6382-1-git-send-email-sumit.garg@linaro.org>

Check if a console is enabled prior to invoking corresponding write
handler.

Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
 kernel/debug/kdb/kdb_io.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 2d42a02..58b7d25 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -560,6 +560,8 @@ static void kdb_msg_write(const char *msg, int msg_len)
 	}
 
 	for_each_console(c) {
+		if (!(c->flags & CON_ENABLED))
+			continue;
 		c->write(c, msg, msg_len);
 		touch_nmi_watchdog();
 	}
-- 
2.7.4


  parent reply	other threads:[~2020-06-03  7:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-03  7:22 [PATCH v5 0/4] kdb: Improve console handling Sumit Garg
2020-06-03  7:22 ` [PATCH v5 1/4] kdb: Re-factor kdb_printf() message write code Sumit Garg
2020-06-03  8:07   ` Petr Mladek
2020-06-03  7:22 ` Sumit Garg [this message]
2020-06-03  8:08   ` [PATCH v5 2/4] kdb: Check status of console prior to invoking handlers Petr Mladek
2020-06-03  7:22 ` [PATCH v5 3/4] kdb: Make kdb_printf() console handling more robust Sumit Garg
2020-06-03  8:10   ` Petr Mladek
2020-06-03  7:22 ` [PATCH v5 4/4] kdb: Switch to use safer dbg_io_ops over console APIs Sumit Garg
2020-06-03  8:25   ` Petr Mladek
2020-06-03  9:18     ` Daniel Thompson
2020-06-03 11:59       ` Petr Mladek
2020-06-03  9:32     ` Sumit Garg
2020-06-03 11:42       ` Daniel Thompson
2020-06-03 13:05         ` Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1591168935-6382-3-git-send-email-sumit.garg@linaro.org \
    --to=sumit.garg@linaro.org \
    --cc=daniel.thompson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jason.wessel@windriver.com \
    --cc=jslaby@suse.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).