From: Sumit Garg <sumit.garg@linaro.org>
To: daniel.thompson@linaro.org
Cc: kgdb-bugreport@lists.sourceforge.net, jason.wessel@windriver.com,
dianders@chromium.org, pmladek@suse.com,
sergey.senozhatsky@gmail.com, gregkh@linuxfoundation.org,
jslaby@suse.com, linux-kernel@vger.kernel.org,
Sumit Garg <sumit.garg@linaro.org>
Subject: [PATCH v6 2/4] kdb: Check status of console prior to invoking handlers
Date: Thu, 4 Jun 2020 15:31:17 +0530 [thread overview]
Message-ID: <1591264879-25920-3-git-send-email-sumit.garg@linaro.org> (raw)
In-Reply-To: <1591264879-25920-1-git-send-email-sumit.garg@linaro.org>
Check if a console is enabled prior to invoking corresponding write
handler.
Suggested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Revieved-by: Petr Mladek <pmladek@suse.com>
---
kernel/debug/kdb/kdb_io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
index 2d42a02..58b7d25 100644
--- a/kernel/debug/kdb/kdb_io.c
+++ b/kernel/debug/kdb/kdb_io.c
@@ -560,6 +560,8 @@ static void kdb_msg_write(const char *msg, int msg_len)
}
for_each_console(c) {
+ if (!(c->flags & CON_ENABLED))
+ continue;
c->write(c, msg, msg_len);
touch_nmi_watchdog();
}
--
2.7.4
next prev parent reply other threads:[~2020-06-04 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 10:01 [PATCH v6 0/4] kdb: Improve console handling Sumit Garg
2020-06-04 10:01 ` [PATCH v6 1/4] kdb: Re-factor kdb_printf() message write code Sumit Garg
2020-06-04 10:01 ` Sumit Garg [this message]
2020-06-04 10:01 ` [PATCH v6 3/4] kdb: Make kdb_printf() console handling more robust Sumit Garg
2020-06-04 10:01 ` [PATCH v6 4/4] kdb: Switch to use safer dbg_io_ops over console APIs Sumit Garg
2020-06-04 21:12 ` Doug Anderson
2020-06-05 9:53 ` Petr Mladek
2020-06-26 12:13 ` Daniel Thompson
2020-06-26 14:19 ` Greg KH
2020-06-05 3:57 ` [PATCH v6 0/4] kdb: Improve console handling Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591264879-25920-3-git-send-email-sumit.garg@linaro.org \
--to=sumit.garg@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jason.wessel@windriver.com \
--cc=jslaby@suse.com \
--cc=kgdb-bugreport@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).