From: Marco Elver <elver@google.com>
To: elver@google.com
Cc: peterz@infradead.org, bp@alien8.de, tglx@linutronix.de,
mingo@kernel.org, clang-built-linux@googlegroups.com,
paulmck@kernel.org, dvyukov@google.com, glider@google.com,
andreyknvl@google.com, kasan-dev@googlegroups.com,
linux-kernel@vger.kernel.org, x86@kernel.org,
akpm@linux-foundation.org,
Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH -tip v3 2/2] kcov: Unconditionally add -fno-stack-protector to compiler options
Date: Fri, 5 Jun 2020 10:28:39 +0200 [thread overview]
Message-ID: <20200605082839.226418-2-elver@google.com> (raw)
In-Reply-To: <20200605082839.226418-1-elver@google.com>
Unconditionally add -fno-stack-protector to KCOV's compiler options, as
all supported compilers support the option. This saves a compiler
invocation to determine if the option is supported.
Because Clang does not support -fno-conserve-stack, and
-fno-stack-protector was wrapped in the same cc-option, we were missing
-fno-stack-protector with Clang. Unconditionally adding this option
fixes this for Clang.
Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Marco Elver <elver@google.com>
---
v3:
* Do not wrap -fno-stack-protector in cc-option, since all KCOV-supported
compilers support the option as pointed out by Nick.
---
kernel/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/Makefile b/kernel/Makefile
index ce8716a04d0e..71971eb39ee7 100644
--- a/kernel/Makefile
+++ b/kernel/Makefile
@@ -35,7 +35,7 @@ KCOV_INSTRUMENT_stacktrace.o := n
KCOV_INSTRUMENT_kcov.o := n
KASAN_SANITIZE_kcov.o := n
KCSAN_SANITIZE_kcov.o := n
-CFLAGS_kcov.o := $(call cc-option, -fno-conserve-stack -fno-stack-protector)
+CFLAGS_kcov.o := $(call cc-option, -fno-conserve-stack) -fno-stack-protector
# cond_syscall is currently not LTO compatible
CFLAGS_sys_ni.o = $(DISABLE_LTO)
--
2.27.0.278.ge193c7cf3a9-goog
next prev parent reply other threads:[~2020-06-05 8:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 8:28 [PATCH -tip v3 1/2] kcov: Make runtime functions noinstr-compatible Marco Elver
2020-06-05 8:28 ` Marco Elver [this message]
2020-06-05 16:50 ` [PATCH -tip v3 2/2] kcov: Unconditionally add -fno-stack-protector to compiler options Nick Desaulniers
2020-06-05 10:57 ` [PATCH -tip v3 1/2] kcov: Make runtime functions noinstr-compatible Dmitry Vyukov
2020-06-05 12:03 ` Peter Zijlstra
2020-06-05 13:25 ` Andrey Konovalov
2020-06-07 9:37 ` Dmitry Vyukov
2020-06-08 7:48 ` Marco Elver
2020-06-08 7:57 ` Dmitry Vyukov
2020-06-08 11:01 ` Peter Zijlstra
2020-06-11 21:55 ` Peter Zijlstra
2020-06-11 21:58 ` Peter Zijlstra
2020-06-12 11:34 ` Peter Zijlstra
2020-06-12 4:04 ` Dmitry Vyukov
2020-06-12 11:49 ` Marco Elver
2020-06-13 17:24 ` Dmitry Vyukov
2020-06-15 7:53 ` Marco Elver
2020-06-15 14:29 ` Peter Zijlstra
2020-06-15 14:35 ` Peter Zijlstra
2020-06-15 14:53 ` Marco Elver
2020-06-15 15:03 ` Peter Zijlstra
2020-06-15 15:20 ` Peter Zijlstra
2020-06-17 14:32 ` Marco Elver
2020-06-17 14:49 ` Peter Zijlstra
2020-06-17 15:19 ` Peter Zijlstra
2020-06-17 15:19 ` Marco Elver
2020-06-17 15:55 ` Peter Zijlstra
2020-06-17 16:36 ` Peter Zijlstra
2020-06-17 18:06 ` Marco Elver
2020-06-15 14:54 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605082839.226418-2-elver@google.com \
--to=elver@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=bp@alien8.de \
--cc=clang-built-linux@googlegroups.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).