From: Robin Gong <yibin.gong@nxp.com>
To: mark.rutland@arm.com, broonie@kernel.org, robh+dt@kernel.org,
catalin.marinas@arm.com, vkoul@kernel.org, will.deacon@arm.com,
shawnguo@kernel.org, festevam@gmail.com, s.hauer@pengutronix.de,
martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de,
dan.j.williams@intel.com, matthias.schiffer@ew.tq-group.com
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, linux-imx@nxp.com,
dmaengine@vger.kernel.org
Subject: [PATCH v9 08/14] spi: imx: fix ERR009165
Date: Sat, 6 Jun 2020 05:32:29 +0800 [thread overview]
Message-ID: <1591392755-19136-9-git-send-email-yibin.gong@nxp.com> (raw)
In-Reply-To: <1591392755-19136-1-git-send-email-yibin.gong@nxp.com>
Change to XCH mode even in dma mode, please refer to the below
errata:
https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Acked-by: Mark Brown <broonie@kernel.org>
---
drivers/spi/spi-imx.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/spi/spi-imx.c b/drivers/spi/spi-imx.c
index c51cd3a..f82d63f 100644
--- a/drivers/spi/spi-imx.c
+++ b/drivers/spi/spi-imx.c
@@ -591,8 +591,8 @@ static int mx51_ecspi_prepare_transfer(struct spi_imx_data *spi_imx,
ctrl |= mx51_ecspi_clkdiv(spi_imx, t->speed_hz, &clk);
spi_imx->spi_bus_clk = clk;
- if (spi_imx->usedma)
- ctrl |= MX51_ECSPI_CTRL_SMC;
+ /* ERR009165: work in XHC mode as PIO */
+ ctrl &= ~MX51_ECSPI_CTRL_SMC;
writel(ctrl, spi_imx->base + MX51_ECSPI_CTRL);
@@ -623,7 +623,7 @@ static void mx51_setup_wml(struct spi_imx_data *spi_imx)
* and enable DMA request.
*/
writel(MX51_ECSPI_DMA_RX_WML(spi_imx->wml - 1) |
- MX51_ECSPI_DMA_TX_WML(spi_imx->wml) |
+ MX51_ECSPI_DMA_TX_WML(0) |
MX51_ECSPI_DMA_RXT_WML(spi_imx->wml) |
MX51_ECSPI_DMA_TEDEN | MX51_ECSPI_DMA_RXDEN |
MX51_ECSPI_DMA_RXTDEN, spi_imx->base + MX51_ECSPI_DMA);
@@ -1273,10 +1273,6 @@ static int spi_imx_sdma_init(struct device *dev, struct spi_imx_data *spi_imx,
{
int ret;
- /* use pio mode for i.mx6dl chip TKT238285 */
- if (of_machine_is_compatible("fsl,imx6dl"))
- return 0;
-
spi_imx->wml = spi_imx->devtype_data->fifo_size / 2;
/* Prepare for TX DMA: */
--
2.7.4
next prev parent reply other threads:[~2020-06-05 13:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-05 21:32 [PATCH v9 00/14] add ecspi ERR009165 for i.mx6/7 soc family Robin Gong
2020-06-05 21:32 ` [PATCH v9 01/14] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core" Robin Gong
2020-06-05 21:32 ` [PATCH v9 02/14] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores" Robin Gong
2020-06-05 21:32 ` [PATCH v9 03/14] Revert "dmaengine: imx-sdma: refine to load context only once" Robin Gong
2020-06-05 21:32 ` [PATCH v9 04/14] dmaengine: imx-sdma: remove duplicated sdma_load_context Robin Gong
2020-06-05 21:32 ` [PATCH v9 05/14] spi: imx: fallback to PIO if dma setup failure Robin Gong
2020-06-05 15:01 ` Mark Brown
2020-06-05 21:32 ` [PATCH v9 06/14] spi: imx: add dma_sync_sg_for_device after fallback from dma Robin Gong
2020-06-05 21:32 ` [PATCH v9 07/14] dmaengine: imx-sdma: add mcu_2_ecspi script Robin Gong
2020-06-05 21:32 ` Robin Gong [this message]
2020-06-05 21:32 ` [PATCH v9 09/14] spi: imx: remove ERR009165 workaround on i.mx6ul Robin Gong
2020-06-05 21:32 ` [PATCH v9 10/14] spi: imx: add new i.mx6ul compatible name in binding doc Robin Gong
2020-06-05 21:32 ` [PATCH v9 11/14] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul Robin Gong
2020-06-05 21:32 ` [PATCH v9 12/14] dma: imx-sdma: add i.mx6ul compatible name Robin Gong
2020-06-05 21:32 ` [PATCH v9 13/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm Robin Gong
2020-06-05 21:32 ` [PATCH v9 14/14] dmaengine: imx-sdma: add uart rom script Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591392755-19136-9-git-send-email-yibin.gong@nxp.com \
--to=yibin.gong@nxp.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.fuzzey@flowbird.group \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vkoul@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).