From: Chuhong Yuan <hslester96@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Andres Salomon <dilinger@queued.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Adrian Bunk <bunk@stusta.de>,
Markus Elfring <Markus.Elfring@web.de>,
James Simmons <jsimmons@infradead.org>,
David Vrabel <dvrabel@arcom.com>, Andrew Morton <akpm@osdl.org>,
linux-geode@lists.infradead.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Chuhong Yuan <hslester96@gmail.com>
Subject: [PATCH v2] fbdev: geode: Add the missed pci_disable_device() in gx1fb_map_video_memory()
Date: Sat, 6 Jun 2020 00:14:58 +0800 [thread overview]
Message-ID: <20200605161458.2513177-1-hslester96@gmail.com> (raw)
Although gx1fb_probe() has handled the failure of gx1fb_map_video_memory()
partly, it does not call pci_disable_device() as gx1fb_map_video_memory()
calls pci_enable_device().
Add the missed function call to fix the bug.
Fixes: 53eed4ec8bcd ("[PATCH] fbdev: geode updates]")
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
Changes in v2:
- Fix the typo in the subject.
- Modify the label of error handler.
- Refactor the code.
drivers/video/fbdev/geode/gx1fb_core.c | 24 +++++++++++++++++-------
1 file changed, 17 insertions(+), 7 deletions(-)
diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c
index 5d34d89fb665..15645244e4d0 100644
--- a/drivers/video/fbdev/geode/gx1fb_core.c
+++ b/drivers/video/fbdev/geode/gx1fb_core.c
@@ -208,29 +208,39 @@ static int gx1fb_map_video_memory(struct fb_info *info, struct pci_dev *dev)
ret = pci_request_region(dev, 0, "gx1fb (video)");
if (ret < 0)
- return ret;
+ goto err_disable_device;
par->vid_regs = pci_ioremap_bar(dev, 0);
if (!par->vid_regs)
- return -ENOMEM;
+ goto err_nomem;
- if (!request_mem_region(gx_base + 0x8300, 0x100, "gx1fb (display controller)"))
- return -EBUSY;
+ if (!request_mem_region(gx_base + 0x8300, 0x100,
+ "gx1fb (display controller)")) {
+ ret = -EBUSY;
+ goto err_disable_device;
+ }
par->dc_regs = ioremap(gx_base + 0x8300, 0x100);
if (!par->dc_regs)
- return -ENOMEM;
+ goto err_nomem;
if ((fb_len = gx1_frame_buffer_size()) < 0)
- return -ENOMEM;
+ goto err_nomem;
+
info->fix.smem_start = gx_base + 0x800000;
info->fix.smem_len = fb_len;
info->screen_base = ioremap(info->fix.smem_start, info->fix.smem_len);
if (!info->screen_base)
- return -ENOMEM;
+ goto err_nomem;
dev_info(&dev->dev, "%d Kibyte of video memory at 0x%lx\n",
info->fix.smem_len / 1024, info->fix.smem_start);
return 0;
+
+err_nomem:
+ ret = -ENOMEM;
+err_disable_device:
+ pci_disable_device(dev);
+ return ret;
}
static int parse_panel_option(struct fb_info *info)
--
2.26.2
next reply other threads:[~2020-06-05 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200605161558eucas1p1388b824ffc9c65e05a30a71ffff8333a@eucas1p1.samsung.com>
2020-06-05 16:14 ` Chuhong Yuan [this message]
2020-06-09 10:17 ` [PATCH v2] fbdev: geode: Add the missed pci_disable_device() in gx1fb_map_video_memory() Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605161458.2513177-1-hslester96@gmail.com \
--to=hslester96@gmail.com \
--cc=Markus.Elfring@web.de \
--cc=akpm@osdl.org \
--cc=b.zolnierkie@samsung.com \
--cc=bunk@stusta.de \
--cc=dilinger@queued.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvrabel@arcom.com \
--cc=jsimmons@infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-geode@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).