From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: paulmck@kernel.org, josh@joshtriplett.org, rostedt@goodmis.org,
mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
joel@joelfernandes.org, trivial@kernel.org
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [PATCH 4/4] rcu: use gp_seq instead of rcu_gp_seq for consistency
Date: Fri, 12 Jun 2020 10:07:55 +0800 [thread overview]
Message-ID: <20200612020755.50526-5-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200612020755.50526-1-richard.weiyang@linux.alibaba.com>
Commit de30ad512a66 ("rcu: Introduce grace-period sequence numbers")
introduce gp_seq in rcu_state/rcu_node/rcu_data. And this field in last
two structure track the one in first.
While the comment use rcu_gp_seq which is a little misleading for
audience. Let's use the exact name gp_seq for consistency.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
---
kernel/rcu/tree.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index 512829eed545..3356842bc185 100644
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -41,7 +41,7 @@ struct rcu_node {
raw_spinlock_t __private lock; /* Root rcu_node's lock protects */
/* some rcu_state fields as well as */
/* following. */
- unsigned long gp_seq; /* Track rsp->rcu_gp_seq. */
+ unsigned long gp_seq; /* Track rsp->gp_seq. */
unsigned long gp_seq_needed; /* Track furthest future GP request. */
unsigned long completedqs; /* All QSes done for this node. */
unsigned long qsmask; /* CPUs or groups that need to switch in */
@@ -149,7 +149,7 @@ union rcu_noqs {
/* Per-CPU data for read-copy update. */
struct rcu_data {
/* 1) quiescent-state and grace-period handling : */
- unsigned long gp_seq; /* Track rsp->rcu_gp_seq counter. */
+ unsigned long gp_seq; /* Track rsp->gp_seq. */
unsigned long gp_seq_needed; /* Track furthest future GP request. */
union rcu_noqs cpu_no_qs; /* No QSes yet for this CPU. */
bool core_needs_qs; /* Core waits for quiesc state. */
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-06-12 2:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 2:07 [PATCH 0/4] rcu: trivial adjust for comments Wei Yang
2020-06-12 2:07 ` [PATCH 1/4] rcu: gp_max is protected by root rcu_node's lock Wei Yang
2020-06-12 2:07 ` [PATCH 2/4] rcu: grplo/grphi just records CPU number Wei Yang
2020-06-12 2:07 ` [PATCH 3/4] rcu: grpnum just records group number Wei Yang
2020-06-12 2:07 ` Wei Yang [this message]
2020-06-12 14:12 ` [PATCH 4/4] rcu: use gp_seq instead of rcu_gp_seq for consistency Paul E. McKenney
2020-06-12 22:10 ` Wei Yang
2020-06-12 23:17 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612020755.50526-5-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).