linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v8 05/13] perf stat: move target check to loop control statement
Date: Wed, 17 Jun 2020 11:38:21 +0300	[thread overview]
Message-ID: <62dc7c05-7195-9001-fbb0-425c6287ad21@linux.intel.com> (raw)
In-Reply-To: <0781a077-aa82-5b4a-273e-c17372a72b93@linux.intel.com>


Check for target existence in loop control statement jointly with 'stop'
indicator based on command line values and external asynchronous 'done'
signal.

Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
---
 tools/perf/builtin-stat.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index 31f7ccf9537b..62bad2df13ba 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -823,10 +823,8 @@ static int __run_perf_stat(int argc, const char **argv, int run_idx)
 			psignal(WTERMSIG(status), argv[0]);
 	} else {
 		enable_counters();
-		while (!done && !stop) {
+		while (!done && !stop && is_target_alive(&target, evsel_list->core.threads)) {
 			nanosleep(&ts, NULL);
-			if (!is_target_alive(&target, evsel_list->core.threads))
-				break;
 			stop = process_timeout(timeout, interval, &times);
 		}
 	}
-- 
2.24.1



  parent reply	other threads:[~2020-06-17  8:38 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-17  8:30 [PATCH v8 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-17  8:35 ` [PATCH v8 01/13] tools/libperf: avoid moving of fds at fdarray__filter() call Alexey Budankov
2020-06-24 17:19   ` Alexey Budankov
2020-06-25 17:14     ` Jiri Olsa
2020-06-25 19:32       ` Alexey Budankov
2020-06-26  9:37         ` Jiri Olsa
2020-06-26 10:06           ` Alexey Budankov
2020-06-29 15:11             ` Alexey Budankov
2020-06-29 19:17               ` Jiri Olsa
2020-06-17  8:35 ` [PATCH v8 02/13] perf evlist: introduce control file descriptors Alexey Budankov
2020-06-17  8:36 ` [PATCH v8 03/13] perf evlist: implement control command handling functions Alexey Budankov
2020-06-23 14:56   ` Jiri Olsa
2020-06-23 15:03     ` Arnaldo Carvalho de Melo
2020-06-23 15:14       ` Jiri Olsa
2020-06-24 13:35         ` Alexey Budankov
2020-06-23 14:56   ` Jiri Olsa
2020-06-24 13:20     ` Alexey Budankov
2020-06-17  8:37 ` [PATCH v8 04/13] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-06-23 14:56   ` Jiri Olsa
2020-06-24 14:27     ` Alexey Budankov
2020-06-25 12:17       ` Jiri Olsa
2020-06-25 16:01         ` Alexey Budankov
2020-06-25 17:13           ` Jiri Olsa
2020-06-25 18:43             ` Alexey Budankov
2020-06-17  8:38 ` Alexey Budankov [this message]
2020-06-17  8:39 ` [PATCH v8 06/13] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-06-17  8:40 ` [PATCH v8 07/13] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-06-23 14:56   ` Jiri Olsa
2020-06-24 13:27     ` Alexey Budankov
2020-06-17  8:40 ` [PATCH v8 08/13] perf stat: extend -D,--delay option with -1 value Alexey Budankov
2020-06-17  8:41 ` [PATCH v8 09/13] perf stat: implement control commands handling Alexey Budankov
2020-06-23 14:54   ` Jiri Olsa
2020-06-24 14:10     ` Alexey Budankov
2020-06-25 12:14       ` Jiri Olsa
2020-06-25 14:58         ` Alexey Budankov
2020-06-23 14:54   ` Jiri Olsa
2020-06-24 13:39     ` Alexey Budankov
2020-06-25 12:12       ` Jiri Olsa
2020-06-25 14:52         ` Alexey Budankov
2020-06-17  8:42 ` [PATCH v8 10/13] perf stat: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-06-17  8:42 ` [PATCH v8 11/13] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-06-17  8:43 ` [PATCH v8 12/13] perf record: implement control commands handling Alexey Budankov
2020-06-23 14:54   ` Jiri Olsa
2020-06-24 14:00     ` Alexey Budankov
2020-06-24 14:55       ` Alexey Budankov
2020-06-25 17:07         ` Jiri Olsa
2020-06-17  8:44 ` [PATCH v8 13/13] perf record: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-06-22  3:38 ` [PATCH v8 00/13] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-06-22  8:55   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62dc7c05-7195-9001-fbb0-425c6287ad21@linux.intel.com \
    --to=alexey.budankov@linux.intel.com \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).