From: Alexander Kapshuk <alexander.kapshuk@gmail.com>
To: ericvh@gmail.com, lucho@ionkov.net, asmadeus@codewreck.org
Cc: davem@davemloft.net, kuba@kernel.org,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, alexander.kapshuk@gmail.com
Subject: [PATCH] net/9p: Fix sparse rcu warnings in client.c
Date: Thu, 18 Jun 2020 21:33:10 +0300 [thread overview]
Message-ID: <20200618183310.5352-1-alexander.kapshuk@gmail.com> (raw)
Address sparse nonderef rcu warnings:
net/9p/client.c:790:17: warning: incorrect type in argument 1 (different address spaces)
net/9p/client.c:790:17: expected struct spinlock [usertype] *lock
net/9p/client.c:790:17: got struct spinlock [noderef] <asn:4> *
net/9p/client.c:792:48: warning: incorrect type in argument 1 (different address spaces)
net/9p/client.c:792:48: expected struct spinlock [usertype] *lock
net/9p/client.c:792:48: got struct spinlock [noderef] <asn:4> *
net/9p/client.c:872:17: warning: incorrect type in argument 1 (different address spaces)
net/9p/client.c:872:17: expected struct spinlock [usertype] *lock
net/9p/client.c:872:17: got struct spinlock [noderef] <asn:4> *
net/9p/client.c:874:48: warning: incorrect type in argument 1 (different address spaces)
net/9p/client.c:874:48: expected struct spinlock [usertype] *lock
net/9p/client.c:874:48: got struct spinlock [noderef] <asn:4> *
Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
net/9p/client.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/net/9p/client.c b/net/9p/client.c
index fc1f3635e5dd..807e0e2e2e5a 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -787,9 +787,15 @@ p9_client_rpc(struct p9_client *c, int8_t type, const char *fmt, ...)
}
recalc_sigpending:
if (sigpending) {
- spin_lock_irqsave(¤t->sighand->siglock, flags);
+ struct sighand_struct *sighand;
+ rcu_read_lock();
+ sighand = rcu_dereference(current->sighand);
+
+ spin_lock_irqsave(&sighand->siglock, flags);
recalc_sigpending();
- spin_unlock_irqrestore(¤t->sighand->siglock, flags);
+ spin_unlock_irqrestore(&sighand->siglock, flags);
+
+ rcu_read_unlock();
}
if (err < 0)
goto reterr;
@@ -869,9 +875,15 @@ static struct p9_req_t *p9_client_zc_rpc(struct p9_client *c, int8_t type,
}
recalc_sigpending:
if (sigpending) {
- spin_lock_irqsave(¤t->sighand->siglock, flags);
+ struct sighand_struct *sighand;
+ rcu_read_lock();
+ sighand = rcu_dereference(current->sighand);
+
+ spin_lock_irqsave(&sighand->siglock, flags);
recalc_sigpending();
- spin_unlock_irqrestore(¤t->sighand->siglock, flags);
+ spin_unlock_irqrestore(&sighand->siglock, flags);
+
+ rcu_read_unlock();
}
if (err < 0)
goto reterr;
--
2.27.0
next reply other threads:[~2020-06-18 18:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 18:33 Alexander Kapshuk [this message]
2020-06-18 19:08 ` [PATCH] net/9p: Fix sparse rcu warnings in client.c Dominique Martinet
2020-06-18 19:40 ` Alexander Kapshuk
2020-06-20 20:14 ` [PATCH] net/9p: Validate current->sighand " Alexander Kapshuk
2020-06-21 8:45 ` Dominique Martinet
2020-06-21 10:30 ` Alexander Kapshuk
2020-06-21 10:56 ` Dominique Martinet
2020-06-21 11:19 ` Alexander Kapshuk
2020-06-21 13:53 ` Alexander Kapshuk
2020-06-21 13:56 ` Dominique Martinet
2020-06-21 13:58 ` Alexander Kapshuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618183310.5352-1-alexander.kapshuk@gmail.com \
--to=alexander.kapshuk@gmail.com \
--cc=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).