From: Ian Rogers <irogers@google.com>
To: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andi Kleen <ak@linux.intel.com>,
Jin Yao <yao.jin@linux.intel.com>,
John Garry <john.garry@huawei.com>,
Adrian Hunter <adrian.hunter@intel.com>,
linux-kernel@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v2 07/10] perf parse-events: Disable a subset of flex warnings
Date: Thu, 18 Jun 2020 21:33:53 -0700 [thread overview]
Message-ID: <20200619043356.90024-8-irogers@google.com> (raw)
In-Reply-To: <20200619043356.90024-1-irogers@google.com>
Rather than disable all warnings with -w, disable specific warnings.
Predicate enabling the warnings on more recent flex versions.
Tested with GCC 9.3.0 and clang 9.0.1.
Signed-off-by: Ian Rogers <irogers@google.com>
---
tools/perf/util/Build | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tools/perf/util/Build b/tools/perf/util/Build
index 504a6bb991ba..53383bd6f4e2 100644
--- a/tools/perf/util/Build
+++ b/tools/perf/util/Build
@@ -221,9 +221,15 @@ $(OUTPUT)util/pmu-bison.c $(OUTPUT)util/pmu-bison.h: util/pmu.y
$(Q)$(call echo-cmd,bison)$(BISON) -v $< -d $(PARSER_DEBUG_BISON) \
-o $(OUTPUT)util/pmu-bison.c -p perf_pmu_
-CFLAGS_parse-events-flex.o += -w
-CFLAGS_pmu-flex.o += -w
-CFLAGS_expr-flex.o += -w
+FLEX_GE_264 := $(shell expr $(shell $(FLEX) --version | sed -e 's/flex \([0-9]\+\).\([0-9]\+\).\([0-9]\+\)/\1\2\3/g') \>\= 264)
+ifeq ($(FLEX_GE_264),1)
+ flex_flags := -Wno-switch-enum -Wno-switch-default -Wno-unused-function -Wno-redundant-decls
+else
+ flex_flags := -w
+endif
+CFLAGS_parse-events-flex.o += $(flex_flags)
+CFLAGS_pmu-flex.o += $(flex_flags)
+CFLAGS_expr-flex.o += $(flex_flags)
CFLAGS_parse-events-bison.o += -DYYENABLE_NLS=0 -w
CFLAGS_pmu-bison.o += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
CFLAGS_expr-bison.o += -DYYENABLE_NLS=0 -DYYLTYPE_IS_TRIVIAL=0 -w
--
2.27.0.111.gc72c7da667-goog
next prev parent reply other threads:[~2020-06-19 4:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 4:33 [PATCH v2 00/10] perf parse-events: enable more flex/bison warnings Ian Rogers
2020-06-19 4:33 ` [PATCH v2 01/10] perf parse-events: Use automatic variable for flex input Ian Rogers
2020-06-19 4:33 ` [PATCH v2 02/10] perf parse-events: Use automatic variable for yacc input Ian Rogers
2020-06-19 4:33 ` [PATCH v2 03/10] perf pmu: Add bison debug build flag Ian Rogers
2020-06-19 4:33 ` [PATCH v2 04/10] perf pmu: Add flex " Ian Rogers
2020-06-19 4:33 ` [PATCH v2 05/10] perf parse-events: Declare flex header file output Ian Rogers
2020-06-19 4:33 ` [PATCH v2 06/10] perf parse-events: Declare bison " Ian Rogers
2020-06-19 4:33 ` Ian Rogers [this message]
2020-06-19 4:33 ` [PATCH v2 08/10] perf expr: Avoid implicit lex function declaration Ian Rogers
2020-06-19 4:33 ` [PATCH v2 09/10] perf parse-events: " Ian Rogers
2020-06-19 4:33 ` [PATCH v2 10/10] perf parse-events: Disable a subset of bison warnings Ian Rogers
2020-06-19 11:50 ` [PATCH v2 00/10] perf parse-events: enable more flex/bison warnings Arnaldo Carvalho de Melo
2020-06-19 12:15 ` Arnaldo Carvalho de Melo
2020-06-19 12:20 ` Arnaldo Carvalho de Melo
2020-06-19 15:15 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619043356.90024-8-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).