From: Vinod Koul <vkoul@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
mani@kernel.org
Subject: [PATCH] spi: spidev: fix missing octal defines
Date: Fri, 19 Jun 2020 13:13:45 +0530 [thread overview]
Message-ID: <20200619074345.4041673-1-vkoul@kernel.org> (raw)
Commit 896fa735084e ("spi: spidev_test: Add support for Octal mode data
transfers") adds support for octal mode but failed to update userspace
header with octal defines causing build error for the spidev tool
spidev_test.c: In function ‘transfer’:
spidev_test.c:131:13: error: ‘SPI_TX_OCTAL’ undeclared (first use in this function); did you mean ‘SPI_TX_DUAL’?
if (mode & SPI_TX_OCTAL)
...
Update the header with octal values.
Fixes: 896fa735084e ("spi: spidev_test: Add support for Octal mode data transfers")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
include/uapi/linux/spi/spidev.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/spi/spidev.h b/include/uapi/linux/spi/spidev.h
index ee0f2460bff6..f0c95f5cc719 100644
--- a/include/uapi/linux/spi/spidev.h
+++ b/include/uapi/linux/spi/spidev.h
@@ -48,6 +48,8 @@
#define SPI_TX_QUAD 0x200
#define SPI_RX_DUAL 0x400
#define SPI_RX_QUAD 0x800
+#define SPI_TX_OCTAL 0x2000
+#define SPI_RX_OCTAL 0x4000
/*---------------------------------------------------------------------------*/
--
2.26.2
next reply other threads:[~2020-06-19 7:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 7:43 Vinod Koul [this message]
2020-06-19 10:23 ` [PATCH] spi: spidev: fix missing octal defines Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619074345.4041673-1-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mani@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).