From: Paolo Bonzini <pbonzini@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org
Subject: [PATCH v2 2/6] selftests: breakpoints: fix computation of test plan
Date: Mon, 22 Jun 2020 20:15:43 -0400 [thread overview]
Message-ID: <20200623001547.22255-3-pbonzini@redhat.com> (raw)
In-Reply-To: <20200623001547.22255-1-pbonzini@redhat.com>
The computation of the test plan uses the available_cpus bitset
before calling sched_getaffinity to fill it in. The resulting
plan is bogus, fix it.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
.../selftests/breakpoints/step_after_suspend_test.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/breakpoints/step_after_suspend_test.c b/tools/testing/selftests/breakpoints/step_after_suspend_test.c
index b3ead29c6089..983ee6182e25 100644
--- a/tools/testing/selftests/breakpoints/step_after_suspend_test.c
+++ b/tools/testing/selftests/breakpoints/step_after_suspend_test.c
@@ -183,6 +183,10 @@ int main(int argc, char **argv)
}
}
+ err = sched_getaffinity(0, sizeof(available_cpus), &available_cpus);
+ if (err < 0)
+ ksft_exit_fail_msg("sched_getaffinity() failed\n");
+
for (cpu = 0; cpu < CPU_SETSIZE; cpu++) {
if (!CPU_ISSET(cpu, &available_cpus))
continue;
@@ -193,10 +197,6 @@ int main(int argc, char **argv)
if (do_suspend)
suspend();
- err = sched_getaffinity(0, sizeof(available_cpus), &available_cpus);
- if (err < 0)
- ksft_exit_fail_msg("sched_getaffinity() failed\n");
-
for (cpu = 0; cpu < CPU_SETSIZE; cpu++) {
bool test_success;
--
2.26.2
next prev parent reply other threads:[~2020-06-23 0:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 0:15 [PATCH v2 0/6] kselftest: fix TAP output for skipped test and ksft_set_plan misuse Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 1/6] kselftest: fix TAP output for skipped tests Paolo Bonzini
2020-06-23 0:15 ` Paolo Bonzini [this message]
2020-06-23 0:15 ` [PATCH v2 3/6] selftests: breakpoints: do not use ksft_exit_skip after ksft_set_plan Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 4/6] selftests: pidfd: " Paolo Bonzini
2020-06-23 20:44 ` Christian Brauner
2020-06-24 6:21 ` Paolo Bonzini
2020-07-06 20:55 ` Shuah Khan
2020-07-07 9:49 ` Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 5/6] selftests: sigaltstack: " Paolo Bonzini
2020-06-23 0:15 ` [PATCH v2 6/6] selftests: sync_test: " Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623001547.22255-3-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).