From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: linux-integrity@vger.kernel.org
Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Kylene Jo Hall <kjhall@us.ibm.com>,
"Ferry Toth :" <ferry.toth@elsinga.info>,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v2] tpm_tis: Remove the HID IFX0102
Date: Thu, 25 Jun 2020 05:31:11 +0300 [thread overview]
Message-ID: <20200625023111.270458-1-jarkko.sakkinen@linux.intel.com> (raw)
Acer C720 running Linux v5.3 reports this in klog:
tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
tpm tpm0: tpm_try_transmit: send(): error -5
tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
tpm_tis tpm_tis: Could not get TPM timeouts and durations
tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
tpm tpm0: tpm_try_transmit: send(): error -5
tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
tpm_tis 00:08: Could not get TPM timeouts and durations
ima: No TPM chip found, activating TPM-bypass!
tpm_inf_pnp 00:08: Found TPM with ID IFX0102
% git --no-pager grep IFX0102 drivers/char/tpm
drivers/char/tpm/tpm_infineon.c: {"IFX0102", 0},
drivers/char/tpm/tpm_tis.c: {"IFX0102", 0}, /* Infineon */
Obviously IFX0102 was added to the HID table for the TCG TIS driver by
mistake.
Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
Cc: Kylene Jo Hall <kjhall@us.ibm.com>
Reported-by: Ferry Toth: <ferry.toth@elsinga.info>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
v2:
git diff -R HEAD~1 -- drivers/char/tpm/tpm2-space.c | patch -p1
git diff -R HEAD~1 -- include/linux/tpm.h | patch -p1
drivers/char/tpm/tpm_tis.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
index e7df342a317d..c58ea10fc92f 100644
--- a/drivers/char/tpm/tpm_tis.c
+++ b/drivers/char/tpm/tpm_tis.c
@@ -238,7 +238,6 @@ static int tpm_tis_pnp_init(struct pnp_dev *pnp_dev,
static struct pnp_device_id tpm_pnp_tbl[] = {
{"PNP0C31", 0}, /* TPM */
{"ATM1200", 0}, /* Atmel */
- {"IFX0102", 0}, /* Infineon */
{"BCM0101", 0}, /* Broadcom */
{"BCM0102", 0}, /* Broadcom */
{"NSC1200", 0}, /* National */
--
2.25.1
next reply other threads:[~2020-06-25 2:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 2:31 Jarkko Sakkinen [this message]
2020-06-25 6:21 ` [PATCH v2] tpm_tis: Remove the HID IFX0102 Jerry Snitselaar
2020-06-25 21:02 ` Jarkko Sakkinen
2020-06-25 21:19 ` Jerry Snitselaar
2020-06-25 21:23 ` James Bottomley
2020-06-26 13:15 ` Jarkko Sakkinen
2020-06-26 14:36 ` James Bottomley
2020-07-02 23:37 ` Jarkko Sakkinen
2020-06-26 13:08 ` Jarkko Sakkinen
2020-06-30 19:15 ` Jerry Snitselaar
2020-07-02 23:38 ` Jarkko Sakkinen
2020-07-06 11:46 ` Peter.Huewe
2020-07-06 14:00 ` Jarkko Sakkinen
2020-07-06 14:43 ` Jarkko Sakkinen
2020-07-06 14:47 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625023111.270458-1-jarkko.sakkinen@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=ferry.toth@elsinga.info \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=kjhall@us.ibm.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).