From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: ulf.hansson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org,
geert+renesas@glider.be, magnus.damm@gmail.com
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: [PATCH/RFC v4 2/4] regulator: fixed: add regulator_ops members for suspend/resume
Date: Fri, 26 Jun 2020 18:32:20 +0900 [thread overview]
Message-ID: <1593163942-5087-3-git-send-email-yoshihiro.shimoda.uh@renesas.com> (raw)
In-Reply-To: <1593163942-5087-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
The regulator-fixed driver is possible to be off by firmware
like PSCI while the system is suspended. If a consumer could get
such a condition from regulator_is_enabled(), it's useful by
consumers.
So, add some regulator_ops members for it. And then, if
regulator-fixed nodes have suitable sub-nodes and properties [1],
regulator_is_enabled() will return false while suspend() of
a consumer.
[1]
- The node has regulator-state-(standby|mem|disk) sub-nodes.
- The node doesn't have regulator-always-on.
- The sub-node has regulator-off-in-suspend property.
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
drivers/regulator/fixed.c | 29 +++++++++++++++++++++++++++++
1 file changed, 29 insertions(+)
diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index d54830e..0bd4a1a 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -35,6 +35,7 @@ struct fixed_voltage_data {
struct clk *enable_clock;
unsigned int clk_enable_counter;
+ bool disabled_in_suspend;
};
struct fixed_dev_type {
@@ -49,6 +50,31 @@ static const struct fixed_dev_type fixed_clkenable_data = {
.has_enable_clock = true,
};
+static int reg_is_enabled(struct regulator_dev *rdev)
+{
+ struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
+
+ return !priv->disabled_in_suspend;
+}
+
+static int reg_prepare_disable(struct regulator_dev *rdev)
+{
+ struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
+
+ priv->disabled_in_suspend = true;
+
+ return 0;
+}
+
+static int reg_resume_early_disable(struct regulator_dev *rdev)
+{
+ struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
+
+ priv->disabled_in_suspend = false;
+
+ return 0;
+}
+
static int reg_clock_enable(struct regulator_dev *rdev)
{
struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
@@ -132,6 +158,9 @@ of_get_fixed_voltage_config(struct device *dev,
}
static struct regulator_ops fixed_voltage_ops = {
+ .is_enabled = reg_is_enabled,
+ .set_prepare_disable = reg_prepare_disable,
+ .clear_resume_early_disable = reg_resume_early_disable,
};
static struct regulator_ops fixed_voltage_clkenabled_ops = {
--
2.7.4
next prev parent reply other threads:[~2020-06-26 9:32 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 9:32 [PATCH/RFC v4 0/4] treewide: add regulator condition on _mmc_suspend() Yoshihiro Shimoda
2020-06-26 9:32 ` [PATCH/RFC v4 1/4] regulator: core: add prepare and resume_early Yoshihiro Shimoda
2020-06-26 14:30 ` Mark Brown
2020-06-29 2:12 ` Yoshihiro Shimoda
2020-06-26 9:32 ` Yoshihiro Shimoda [this message]
2020-06-26 14:39 ` [PATCH/RFC v4 2/4] regulator: fixed: add regulator_ops members for suspend/resume Mark Brown
2020-06-29 2:42 ` Yoshihiro Shimoda
2020-06-29 12:57 ` Mark Brown
2020-06-29 13:40 ` Sudeep Holla
2020-06-29 14:15 ` Geert Uytterhoeven
2020-06-29 15:07 ` Sudeep Holla
2020-06-29 16:14 ` Mark Brown
2020-06-29 16:42 ` Sudeep Holla
2020-06-29 17:26 ` Mark Brown
2020-06-29 17:42 ` Sudeep Holla
2020-06-30 8:29 ` Yoshihiro Shimoda
2020-06-26 9:32 ` [PATCH/RFC v4 3/4] mmc: core: Call mmc_poweroff_nofity() if regulators are disabled Yoshihiro Shimoda
2020-06-26 15:13 ` Mark Brown
2020-06-29 2:49 ` Yoshihiro Shimoda
2020-06-26 15:53 ` Sergei Shtylyov
2020-06-29 5:16 ` Yoshihiro Shimoda
2020-06-26 9:32 ` [PATCH/RFC v4 4/4] arm64: dts: renesas: add regulator-off-in-suspend property for eMMC Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1593163942-5087-3-git-send-email-yoshihiro.shimoda.uh@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).