linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
	yang.shi@linux.alibaba.com, vbabka@suse.cz, willy@infradead.org,
	thomas_os@shipmail.org, thellstrom@vmware.com,
	anshuman.khandual@arm.com, sean.j.christopherson@intel.com,
	aneesh.kumar@linux.ibm.com, peterx@redhat.com, walken@google.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	digetx@gmail.com, Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd()
Date: Fri, 26 Jun 2020 21:52:13 +0800	[thread overview]
Message-ID: <20200626135216.24314-2-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200626135216.24314-1-richard.weiyang@linux.alibaba.com>

No functional change, just improve the readability and prepare for
following cleanup.

Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
---
 mm/mremap.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mm/mremap.c b/mm/mremap.c
index 5dd572d57ca9..97bf9a2a8bd5 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -200,8 +200,9 @@ static bool move_normal_pmd(struct vm_area_struct *vma, unsigned long old_addr,
 	struct mm_struct *mm = vma->vm_mm;
 	pmd_t pmd;
 
-	if ((old_addr & ~PMD_MASK) || (new_addr & ~PMD_MASK)
-	    || old_end - old_addr < PMD_SIZE)
+	if ((old_addr & ~PMD_MASK) ||
+	    (new_addr & ~PMD_MASK) ||
+	    old_end - old_addr < PMD_SIZE)
 		return false;
 
 	/*
-- 
2.20.1 (Apple Git-117)


  reply	other threads:[~2020-06-26 13:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 13:52 [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-06-26 13:52 ` Wei Yang [this message]
2020-07-06 10:06   ` [RESEND Patch v2 1/4] mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd() Kirill A. Shutemov
2020-06-26 13:52 ` [RESEND Patch v2 2/4] mm/mremap: it is sure to have enough space when extent meets requirement Wei Yang
2020-06-26 13:52 ` [RESEND Patch v2 3/4] mm/mremap: calculate extent in one place Wei Yang
2020-07-06 10:07   ` Kirill A. Shutemov
2020-07-07  1:38     ` Wei Yang
2020-07-07 10:47       ` Kirill A. Shutemov
2020-07-07 12:53         ` Wei Yang
2020-06-26 13:52 ` [RESEND Patch v2 4/4] mm/mremap: start addresses are properly aligned Wei Yang
2020-07-06 10:08 ` [RESEND Patch v2 0/4] mm/mremap: cleanup move_page_tables() a little Kirill A. Shutemov
2020-07-06 22:06   ` Wei Yang
2020-07-06 23:04     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626135216.24314-2-richard.weiyang@linux.alibaba.com \
    --to=richard.weiyang@linux.alibaba.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=digetx@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=peterx@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=thellstrom@vmware.com \
    --cc=thomas_os@shipmail.org \
    --cc=vbabka@suse.cz \
    --cc=walken@google.com \
    --cc=willy@infradead.org \
    --cc=yang.shi@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).