From: Robert Marko <robert.marko@sartura.hr>
To: andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, robh+dt@kernel.org
Cc: Robert Marko <robert.marko@sartura.hr>
Subject: [net-next,PATCH 2/4] net: mdio-ipq4019: add clock support
Date: Thu, 2 Jul 2020 12:29:59 +0200 [thread overview]
Message-ID: <20200702103001.233961-3-robert.marko@sartura.hr> (raw)
In-Reply-To: <20200702103001.233961-1-robert.marko@sartura.hr>
Some newer SoC-s have a separate MDIO clock that needs to be enabled.
So lets add support for handling the clocks to the driver.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
drivers/net/phy/mdio-ipq4019.c | 28 +++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-ipq4019.c b/drivers/net/phy/mdio-ipq4019.c
index 0e78830c070b..7660bf006da0 100644
--- a/drivers/net/phy/mdio-ipq4019.c
+++ b/drivers/net/phy/mdio-ipq4019.c
@@ -9,6 +9,7 @@
#include <linux/iopoll.h>
#include <linux/of_address.h>
#include <linux/of_mdio.h>
+#include <linux/clk.h>
#include <linux/phy.h>
#include <linux/platform_device.h>
@@ -24,8 +25,12 @@
#define IPQ4019_MDIO_TIMEOUT 10000
#define IPQ4019_MDIO_SLEEP 10
+#define QCA_MDIO_CLK_DEFAULT_RATE 100000000
+
struct ipq4019_mdio_data {
- void __iomem *membase;
+ void __iomem *membase;
+ struct clk *mdio_clk;
+ u32 clk_freq;
};
static int ipq4019_mdio_wait_busy(struct mii_bus *bus)
@@ -100,6 +105,7 @@ static int ipq4019_mdio_probe(struct platform_device *pdev)
{
struct ipq4019_mdio_data *priv;
struct mii_bus *bus;
+ struct device_node *np = pdev->dev.of_node;
int ret;
bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*priv));
@@ -112,6 +118,26 @@ static int ipq4019_mdio_probe(struct platform_device *pdev)
if (IS_ERR(priv->membase))
return PTR_ERR(priv->membase);
+ priv->mdio_clk = devm_clk_get_optional(&pdev->dev, "mdio_ahb");
+ if (!IS_ERR(priv->mdio_clk)) {
+ if (of_property_read_u32(np, "clock-frequency", &priv->clk_freq)) {
+ dev_warn(&pdev->dev, "Cannot find MDIO clock frequency, using default!\n");
+ priv->clk_freq = QCA_MDIO_CLK_DEFAULT_RATE;
+ }
+
+ ret = clk_set_rate(priv->mdio_clk, priv->clk_freq);
+ if (ret) {
+ dev_err(&pdev->dev, "Cannot set MDIO clock rate!\n");
+ return ret;
+ }
+
+ ret = clk_prepare_enable(priv->mdio_clk);
+ if (ret) {
+ dev_err(&pdev->dev, "Cannot enable MDIO clock!\n");
+ return ret;
+ }
+ }
+
bus->name = "ipq4019_mdio";
bus->read = ipq4019_mdio_read;
bus->write = ipq4019_mdio_write;
--
2.26.2
next prev parent reply other threads:[~2020-07-02 10:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 10:29 [net-next,PATCH 0/4] net: mdio-ipq4019: add Clause 45 and clock support Robert Marko
2020-07-02 10:29 ` [net-next,PATCH 1/4] net: mdio-ipq4019: change defines to upper case Robert Marko
2020-07-02 13:25 ` Andrew Lunn
2020-07-02 19:58 ` Florian Fainelli
2020-07-02 10:29 ` Robert Marko [this message]
2020-07-02 13:29 ` [net-next,PATCH 2/4] net: mdio-ipq4019: add clock support Andrew Lunn
2020-07-02 19:59 ` Florian Fainelli
2020-07-03 11:37 ` Robert Marko
2020-07-03 13:35 ` Andrew Lunn
2020-07-02 10:30 ` [net-next,PATCH 3/4] net: mdio-ipq4019: add Clause 45 support Robert Marko
2020-07-02 13:35 ` Andrew Lunn
2020-07-02 10:30 ` [net-next,PATCH 4/4] dt-bindings: mdio-ipq4019: add clock support Robert Marko
2020-07-02 13:38 ` Andrew Lunn
2020-07-02 19:18 ` Robert Marko
2020-07-02 20:04 ` Florian Fainelli
2020-07-03 7:44 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702103001.233961-3-robert.marko@sartura.hr \
--to=robert.marko@sartura.hr \
--cc=agross@kernel.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).