Logo crash
diff mbox series

Message ID Pine.GSO.4.21.0301051744260.10559-100000@vervain.sonytel.be
State New, archived
Headers show
Series
  • Logo crash
Related show

Commit Message

Geert Uytterhoeven Jan. 5, 2003, 4:47 p.m. UTC
The local variable palette_cmap.transp is not initialized, so it can contain
garbage, causing a crash during logo drawing.


Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Comments

James Simmons Jan. 5, 2003, 8:39 p.m. UTC | #1
> The local variable palette_cmap.transp is not initialized, so it can contain
> garbage, causing a crash during logo drawing.
> 
> --- linux-2.5.54/drivers/video/fbmem.c	Thu Jan  2 12:54:58 2003
> +++ linux-m68k-2.5.54/drivers/video/fbmem.c	Sun Jan  5 17:22:57 2003
> @@ -386,6 +386,7 @@
>  	palette_cmap.red = palette_red;
>  	palette_cmap.green = palette_green;
>  	palette_cmap.blue = palette_blue;
> +	palette_cmap.transp = 0;
>  
>  	for (i = 0; i < LINUX_LOGO_COLORS; i += n) {
>  		n = LINUX_LOGO_COLORS - i;

Applied.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch
diff mbox series

--- linux-2.5.54/drivers/video/fbmem.c	Thu Jan  2 12:54:58 2003
+++ linux-m68k-2.5.54/drivers/video/fbmem.c	Sun Jan  5 17:22:57 2003
@@ -386,6 +386,7 @@ 
 	palette_cmap.red = palette_red;
 	palette_cmap.green = palette_green;
 	palette_cmap.blue = palette_blue;
+	palette_cmap.transp = 0;
 
 	for (i = 0; i < LINUX_LOGO_COLORS; i += n) {
 		n = LINUX_LOGO_COLORS - i;