From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: [PATCH] Logo crash
Date: Sun, 5 Jan 2003 17:47:35 +0100 (MET) [thread overview]
Message-ID: <Pine.GSO.4.21.0301051744260.10559-100000@vervain.sonytel.be> (raw)
The local variable palette_cmap.transp is not initialized, so it can contain
garbage, causing a crash during logo drawing.
--- linux-2.5.54/drivers/video/fbmem.c Thu Jan 2 12:54:58 2003
+++ linux-m68k-2.5.54/drivers/video/fbmem.c Sun Jan 5 17:22:57 2003
@@ -386,6 +386,7 @@
palette_cmap.red = palette_red;
palette_cmap.green = palette_green;
palette_cmap.blue = palette_blue;
+ palette_cmap.transp = 0;
for (i = 0; i < LINUX_LOGO_COLORS; i += n) {
n = LINUX_LOGO_COLORS - i;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next reply other threads:[~2003-01-05 16:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-05 16:47 Geert Uytterhoeven [this message]
2003-01-05 20:39 ` [Linux-fbdev-devel] [PATCH] Logo crash James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.21.0301051744260.10559-100000@vervain.sonytel.be \
--to=geert@linux-m68k.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).