From: <qiang.zhang@windriver.com>
To: <ben.dooks@codethink.co.uk>, <bfields@redhat.com>,
<cl@rock-chips.com>, <peterz@infradead.org>, <pmladek@suse.com>,
<tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] kthread: work could not be queued when worker being destroyed
Date: Thu, 2 Jul 2020 15:01:56 +0800 [thread overview]
Message-ID: <20200702070156.5862-1-qiang.zhang@windriver.com> (raw)
From: Zhang Qiang <qiang.zhang@windriver.com>
The "queuing_blocked" func should print warning message and
returns true when the worker being destroyed.
Suggested-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
---
v1->v2:
Add warning information for condition "!worker->task"
kernel/kthread.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/kthread.c b/kernel/kthread.c
index bfbfa481be3a..cac5184ffd86 100644
--- a/kernel/kthread.c
+++ b/kernel/kthread.c
@@ -791,6 +791,9 @@ static inline bool queuing_blocked(struct kthread_worker *worker,
{
lockdep_assert_held(&worker->lock);
+ if (WARN_ON(!worker->task))
+ return true;
+
return !list_empty(&work->node) || work->canceling;
}
--
2.24.1
next reply other threads:[~2020-07-03 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 7:01 qiang.zhang [this message]
2020-07-03 11:11 ` [PATCH v2] kthread: work could not be queued when worker being destroyed Petr Mladek
2020-07-03 19:13 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702070156.5862-1-qiang.zhang@windriver.com \
--to=qiang.zhang@windriver.com \
--cc=ben.dooks@codethink.co.uk \
--cc=bfields@redhat.com \
--cc=cl@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).