From: Lee Jones <lee.jones@linaro.org>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Peter Chen <Peter.Chen@nxp.com>
Subject: [PATCH 10/30] usb: chipidea: debug: Demote obvious misuse of kerneldoc to standard comment blocks
Date: Fri, 3 Jul 2020 18:41:28 +0100 [thread overview]
Message-ID: <20200703174148.2749969-11-lee.jones@linaro.org> (raw)
In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org>
No attempt has been made to document any of the demoted functions here.
Fixes the following W=1 kernel build warning(s):
drivers/usb/chipidea/debug.c:25: warning: Function parameter or member 's' not described in 'ci_device_show'
drivers/usb/chipidea/debug.c:25: warning: Function parameter or member 'data' not described in 'ci_device_show'
drivers/usb/chipidea/debug.c:54: warning: Function parameter or member 's' not described in 'ci_port_test_show'
drivers/usb/chipidea/debug.c:54: warning: Function parameter or member 'data' not described in 'ci_port_test_show'
drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'file' not described in 'ci_port_test_write'
drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'ubuf' not described in 'ci_port_test_write'
drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'count' not described in 'ci_port_test_write'
drivers/usb/chipidea/debug.c:75: warning: Function parameter or member 'ppos' not described in 'ci_port_test_write'
drivers/usb/chipidea/debug.c:122: warning: Function parameter or member 's' not described in 'ci_qheads_show'
drivers/usb/chipidea/debug.c:122: warning: Function parameter or member 'data' not described in 'ci_qheads_show'
drivers/usb/chipidea/debug.c:154: warning: Function parameter or member 's' not described in 'ci_requests_show'
drivers/usb/chipidea/debug.c:154: warning: Function parameter or member 'data' not described in 'ci_requests_show'
Cc: Peter Chen <Peter.Chen@nxp.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/usb/chipidea/debug.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/chipidea/debug.c b/drivers/usb/chipidea/debug.c
index e0376ee646adf..da5d18cf68406 100644
--- a/drivers/usb/chipidea/debug.c
+++ b/drivers/usb/chipidea/debug.c
@@ -18,7 +18,7 @@
#include "bits.h"
#include "otg.h"
-/**
+/*
* ci_device_show: prints information about device capabilities and status
*/
static int ci_device_show(struct seq_file *s, void *data)
@@ -47,7 +47,7 @@ static int ci_device_show(struct seq_file *s, void *data)
}
DEFINE_SHOW_ATTRIBUTE(ci_device);
-/**
+/*
* ci_port_test_show: reads port test mode
*/
static int ci_port_test_show(struct seq_file *s, void *data)
@@ -67,7 +67,7 @@ static int ci_port_test_show(struct seq_file *s, void *data)
return 0;
}
-/**
+/*
* ci_port_test_write: writes port test mode
*/
static ssize_t ci_port_test_write(struct file *file, const char __user *ubuf,
@@ -115,7 +115,7 @@ static const struct file_operations ci_port_test_fops = {
.release = single_release,
};
-/**
+/*
* ci_qheads_show: DMA contents of all queue heads
*/
static int ci_qheads_show(struct seq_file *s, void *data)
@@ -147,7 +147,7 @@ static int ci_qheads_show(struct seq_file *s, void *data)
}
DEFINE_SHOW_ATTRIBUTE(ci_qheads);
-/**
+/*
* ci_requests_show: DMA contents of all requests currently queued (all endpts)
*/
static int ci_requests_show(struct seq_file *s, void *data)
--
2.25.1
next prev parent reply other threads:[~2020-07-03 17:42 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 17:41 [PATCH 00/30] Fix a bunch more W=1 issues in USB Lee Jones
2020-07-03 17:41 ` [PATCH 01/30] usb: mtu3: mtu3_debug: Add forward declaration of 'struct ssusb_mtk' Lee Jones
2020-07-03 17:41 ` [PATCH 02/30] usb: host: ohci-s3c2410: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41 ` [PATCH 03/30] usb: core: ledtrig-usbport: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 04/30] usb: misc: sisusbvga: sisusb_init: Mark all 'static const' arrays as __maybe_unused Lee Jones
2020-07-03 18:29 ` Joe Perches
2020-07-03 19:44 ` Lee Jones
2020-07-07 8:03 ` Lee Jones
2020-07-07 20:50 ` Joe Perches
2020-07-08 6:34 ` Lee Jones
2020-07-07 7:49 ` Lee Jones
2020-07-03 17:41 ` [PATCH 05/30] usb: atm: ueagle-atm: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 06/30] usb: misc: adutux: " Lee Jones
2020-07-03 17:41 ` [PATCH 07/30] usb: chipidea: core: Document hw_port_test_set()'s missing 'ci' argument Lee Jones
2020-07-03 17:41 ` [PATCH 08/30] usb: gadget: udc: core: Fix a bunch of kerneldoc misdemeanours Lee Jones
2020-07-03 17:41 ` [PATCH 09/30] usb: chipidea: otg: Fix kerneldoc issues relating to description of 'ci' Lee Jones
2020-07-03 17:41 ` Lee Jones [this message]
2020-07-03 17:41 ` [PATCH 11/30] usb: chipidea: udc: Add missing descriptions for function arg 'ci' Lee Jones
2020-07-03 17:41 ` [PATCH 12/30] usb: chipidea: udc: Help out kerneldoc headers that have tried, demote the others Lee Jones
2020-07-03 17:41 ` [PATCH 13/30] usb: host: xhci: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41 ` [PATCH 14/30] usb: host: xhci-mem: " Lee Jones
2020-07-03 17:41 ` [PATCH 15/30] usb: host: xhci-dbgcap: File headers are not good candidates for kerneldoc Lee Jones
2020-07-03 17:41 ` [PATCH 16/30] usb: host: xhci-dbgtty: " Lee Jones
2020-07-03 17:41 ` [PATCH 17/30] usb: chipidea: udc: Fix a few kerneldoc issues Lee Jones
2020-07-03 17:41 ` [PATCH 18/30] usb: host: xhci-debugfs: Use 'gnu_printf' format notation Lee Jones
2020-07-03 17:41 ` [PATCH 19/30] usb: storage: alauda: Remove set but unchecked variable Lee Jones
2020-07-03 17:41 ` [PATCH 20/30] usb: typec: altmodes: displayport: File headers are not good candidates for kerneldoc Lee Jones
2020-07-03 17:41 ` [PATCH 21/30] usb: typec: altmodes: displayport: Supply missing displayport.h include file Lee Jones
2020-07-03 17:41 ` [PATCH 22/30] usb: typec: tcpm: fusb302: Use 'gnu_printf' format notation Lee Jones
2020-07-03 19:01 ` Guenter Roeck
2020-07-03 17:41 ` [PATCH 23/30] usb: chipidea: usbmisc_imx: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41 ` [PATCH 24/30] usb: misc: iowarrior: Fix odd corruption issue in the file header Lee Jones
2020-07-03 17:41 ` [PATCH 25/30] usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 26/30] usb: gadget: function: u_serial: Repair misdocumented function argument Lee Jones
2020-07-03 17:41 ` [PATCH 27/30] usb: misc: ldusb: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 28/30] usb: musb: musb_dsps: " Lee Jones
2020-07-03 17:41 ` [PATCH 29/30] usb: gadget: usbstring: Repair misspelled function argument 'langid' Lee Jones
2020-07-03 17:41 ` [PATCH 30/30] usb: gadget: udc: dummy_hcd: Repair misspelled function argument 'dummy_hcd' Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200703174148.2749969-11-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=Peter.Chen@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).