linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: [PATCH 21/30] usb: typec: altmodes: displayport: Supply missing displayport.h include file
Date: Fri,  3 Jul 2020 18:41:39 +0100	[thread overview]
Message-ID: <20200703174148.2749969-22-lee.jones@linaro.org> (raw)
In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org>

If the header file containing a function's prototype isn't included by
the sourcefile containing the associated function, the build system
complains of missing prototypes.

Fixes the following W=1 kernel build warning(s):

 drivers/usb/typec/altmodes/displayport.c:511:5: warning: no previous prototype for ‘dp_altmode_probe’ [-Wmissing-prototypes]
 drivers/usb/typec/altmodes/displayport.c:551:6: warning: no previous prototype for ‘dp_altmode_remove’ [-Wmissing-prototypes]

Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/usb/typec/altmodes/displayport.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/typec/altmodes/displayport.c b/drivers/usb/typec/altmodes/displayport.c
index d617663b981dd..7b20073d7fc0a 100644
--- a/drivers/usb/typec/altmodes/displayport.c
+++ b/drivers/usb/typec/altmodes/displayport.c
@@ -13,6 +13,7 @@
 #include <linux/module.h>
 #include <linux/usb/pd_vdo.h>
 #include <linux/usb/typec_dp.h>
+#include "displayport.h"
 
 #define DP_HEADER(_dp, cmd)		(VDO((_dp)->alt->svid, 1, cmd) | \
 					 VDO_OPOS(USB_TYPEC_DP_MODE))
-- 
2.25.1


  parent reply	other threads:[~2020-07-03 17:42 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-03 17:41 [PATCH 00/30] Fix a bunch more W=1 issues in USB Lee Jones
2020-07-03 17:41 ` [PATCH 01/30] usb: mtu3: mtu3_debug: Add forward declaration of 'struct ssusb_mtk' Lee Jones
2020-07-03 17:41 ` [PATCH 02/30] usb: host: ohci-s3c2410: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41 ` [PATCH 03/30] usb: core: ledtrig-usbport: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 04/30] usb: misc: sisusbvga: sisusb_init: Mark all 'static const' arrays as __maybe_unused Lee Jones
2020-07-03 18:29   ` Joe Perches
2020-07-03 19:44     ` Lee Jones
2020-07-07  8:03     ` Lee Jones
2020-07-07 20:50       ` Joe Perches
2020-07-08  6:34         ` Lee Jones
2020-07-07  7:49   ` Lee Jones
2020-07-03 17:41 ` [PATCH 05/30] usb: atm: ueagle-atm: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 06/30] usb: misc: adutux: " Lee Jones
2020-07-03 17:41 ` [PATCH 07/30] usb: chipidea: core: Document hw_port_test_set()'s missing 'ci' argument Lee Jones
2020-07-03 17:41 ` [PATCH 08/30] usb: gadget: udc: core: Fix a bunch of kerneldoc misdemeanours Lee Jones
2020-07-03 17:41 ` [PATCH 09/30] usb: chipidea: otg: Fix kerneldoc issues relating to description of 'ci' Lee Jones
2020-07-03 17:41 ` [PATCH 10/30] usb: chipidea: debug: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 11/30] usb: chipidea: udc: Add missing descriptions for function arg 'ci' Lee Jones
2020-07-03 17:41 ` [PATCH 12/30] usb: chipidea: udc: Help out kerneldoc headers that have tried, demote the others Lee Jones
2020-07-03 17:41 ` [PATCH 13/30] usb: host: xhci: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41 ` [PATCH 14/30] usb: host: xhci-mem: " Lee Jones
2020-07-03 17:41 ` [PATCH 15/30] usb: host: xhci-dbgcap: File headers are not good candidates for kerneldoc Lee Jones
2020-07-03 17:41 ` [PATCH 16/30] usb: host: xhci-dbgtty: " Lee Jones
2020-07-03 17:41 ` [PATCH 17/30] usb: chipidea: udc: Fix a few kerneldoc issues Lee Jones
2020-07-03 17:41 ` [PATCH 18/30] usb: host: xhci-debugfs: Use 'gnu_printf' format notation Lee Jones
2020-07-03 17:41 ` [PATCH 19/30] usb: storage: alauda: Remove set but unchecked variable Lee Jones
2020-07-03 17:41 ` [PATCH 20/30] usb: typec: altmodes: displayport: File headers are not good candidates for kerneldoc Lee Jones
2020-07-03 17:41 ` Lee Jones [this message]
2020-07-03 17:41 ` [PATCH 22/30] usb: typec: tcpm: fusb302: Use 'gnu_printf' format notation Lee Jones
2020-07-03 19:01   ` Guenter Roeck
2020-07-03 17:41 ` [PATCH 23/30] usb: chipidea: usbmisc_imx: Demote obvious misuse of kerneldoc to standard comment block Lee Jones
2020-07-03 17:41 ` [PATCH 24/30] usb: misc: iowarrior: Fix odd corruption issue in the file header Lee Jones
2020-07-03 17:41 ` [PATCH 25/30] usb: misc: iowarrior: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 26/30] usb: gadget: function: u_serial: Repair misdocumented function argument Lee Jones
2020-07-03 17:41 ` [PATCH 27/30] usb: misc: ldusb: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-03 17:41 ` [PATCH 28/30] usb: musb: musb_dsps: " Lee Jones
2020-07-03 17:41 ` [PATCH 29/30] usb: gadget: usbstring: Repair misspelled function argument 'langid' Lee Jones
2020-07-03 17:41 ` [PATCH 30/30] usb: gadget: udc: dummy_hcd: Repair misspelled function argument 'dummy_hcd' Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200703174148.2749969-22-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).