From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: dhowells@redhat.com, linux-cachefs@redhat.com,
linux-kernel@vger.kernel.org
Cc: "Jason A. Donenfeld" <Jason@zx2c4.com>
Subject: [PATCH] fscache: replace open-coded pr_warn_once() with actual call
Date: Sun, 5 Jul 2020 16:43:24 -0600 [thread overview]
Message-ID: <20200705224324.16090-1-Jason@zx2c4.com> (raw)
There's no reason to open code this here, so instead replace it with
pr_warn_once, which amounts to exactly the same thing.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
fs/fscache/page.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/fs/fscache/page.c b/fs/fscache/page.c
index 26af6fdf1538..dc8dce79fa8d 100644
--- a/fs/fscache/page.c
+++ b/fs/fscache/page.c
@@ -1173,14 +1173,9 @@ void fscache_mark_page_cached(struct fscache_retrieval *op, struct page *page)
trace_fscache_page(cookie, page, fscache_page_cached);
_debug("- mark %p{%lx}", page, page->index);
- if (TestSetPageFsCache(page)) {
- static bool once_only;
- if (!once_only) {
- once_only = true;
- pr_warn("Cookie type %s marked page %lx multiple times\n",
- cookie->def->name, page->index);
- }
- }
+ if (TestSetPageFsCache(page))
+ pr_warn_once("Cookie type %s marked page %lx multiple times\n",
+ cookie->def->name, page->index);
if (cookie->def->mark_page_cached)
cookie->def->mark_page_cached(cookie->netfs_data,
--
2.27.0
next reply other threads:[~2020-07-05 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 22:43 Jason A. Donenfeld [this message]
2020-07-06 14:23 ` [PATCH] fscache: replace open-coded pr_warn_once() with actual call David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200705224324.16090-1-Jason@zx2c4.com \
--to=jason@zx2c4.com \
--cc=dhowells@redhat.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).