From: Jia He <justin.he@arm.com>
To: Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@linux.ibm.com>, Baoquan He <bhe@redhat.com>,
Chuhong Yuan <hslester96@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Kaly Xin <Kaly.Xin@arm.com>, Jia He <justin.he@arm.com>
Subject: [PATCH 1/3] arm64/numa: set numa_off to false when numa node is fake
Date: Mon, 6 Jul 2020 09:19:45 +0800 [thread overview]
Message-ID: <20200706011947.184166-2-justin.he@arm.com> (raw)
In-Reply-To: <20200706011947.184166-1-justin.he@arm.com>
Previously, numa_off is set to true unconditionally in dummy_numa_init(),
even if there is a fake numa node.
But acpi will translate node id to NUMA_NO_NODE(-1) in acpi_map_pxm_to_node()
because it regards numa_off as turning off the numa node.
Without this patch, pmem can't be probed as a RAM device on arm64 if SRAT table
isn't present.
$ndctl create-namespace -fe namespace0.0 --mode=devdax --map=dev -s 1g -a 64K
kmem dax0.0: rejecting DAX region [mem 0x240400000-0x2bfffffff] with invalid node: -1
kmem: probe of dax0.0 failed with error -22
This fixes it by setting numa_off to false.
Signed-off-by: Jia He <justin.he@arm.com>
---
arch/arm64/mm/numa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/mm/numa.c b/arch/arm64/mm/numa.c
index aafcee3e3f7e..7689986020d9 100644
--- a/arch/arm64/mm/numa.c
+++ b/arch/arm64/mm/numa.c
@@ -440,7 +440,8 @@ static int __init dummy_numa_init(void)
return ret;
}
- numa_off = true;
+ /* force numa_off to be false since we have a fake numa node here */
+ numa_off = false;
return 0;
}
--
2.17.1
next prev parent reply other threads:[~2020-07-06 1:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 1:19 [PATCH 0/3] Fix and enable pmem as RAM on arm64 Jia He
2020-07-06 1:19 ` Jia He [this message]
2020-07-06 8:02 ` [PATCH 1/3] arm64/numa: set numa_off to false when numa node is fake David Hildenbrand
2020-07-06 12:36 ` Justin He
2020-07-06 13:56 ` David Hildenbrand
2020-07-06 10:29 ` Jonathan Cameron
2020-07-06 10:46 ` Jonathan Cameron
2020-07-06 12:47 ` Justin He
2020-07-06 13:03 ` Jonathan Cameron
2020-07-06 1:19 ` [PATCH 2/3] mm/memory_hotplug: harden try_offline_node against bogus nid Jia He
2020-07-06 7:57 ` David Hildenbrand
2020-07-06 13:45 ` Justin He
2020-07-06 1:19 ` [PATCH 3/3] mm/memory_hotplug: fix unpaired mem_hotplug_begin/done Jia He
2020-07-06 7:49 ` David Hildenbrand
2020-07-07 22:10 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706011947.184166-2-justin.he@arm.com \
--to=justin.he@arm.com \
--cc=Kaly.Xin@arm.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=hslester96@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).