From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
vbabka@suse.cz, yang.shi@linux.alibaba.com,
thomas_os@shipmail.org, anshuman.khandual@arm.com,
sean.j.christopherson@intel.com,
richard.weiyang@linux.alibaba.com, peterx@redhat.com,
aneesh.kumar@linux.ibm.com, willy@infradead.org,
thellstrom@vmware.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, digetx@gmail.com
Subject: [Patch v3 2/4] mm/mremap: calculate extent in one place
Date: Wed, 8 Jul 2020 09:24:51 +0800 [thread overview]
Message-ID: <20200708012453.36588-3-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200708012453.36588-1-richard.weiyang@linux.alibaba.com>
Page tables is moved on the base of PMD. This requires both source
and destination range should meet the requirement.
Current code works well since move_huge_pmd() and move_normal_pmd()
would check old_addr and new_addr again. And then return to move_ptes()
if the either of them is not aligned.
In stead of calculating the extent separately, it is better to calculate
in one place, so we know it is not necessary to try move pmd. By doing
so, the logic seems a little clear.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
---
mm/mremap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/mremap.c b/mm/mremap.c
index de27b12c8a5a..a30b3e86cc99 100644
--- a/mm/mremap.c
+++ b/mm/mremap.c
@@ -258,6 +258,9 @@ unsigned long move_page_tables(struct vm_area_struct *vma,
extent = next - old_addr;
if (extent > old_end - old_addr)
extent = old_end - old_addr;
+ next = (new_addr + PMD_SIZE) & PMD_MASK;
+ if (extent > next - new_addr)
+ extent = next - new_addr;
old_pmd = get_old_pmd(vma->vm_mm, old_addr);
if (!old_pmd)
continue;
@@ -301,9 +304,6 @@ unsigned long move_page_tables(struct vm_area_struct *vma,
if (pte_alloc(new_vma->vm_mm, new_pmd))
break;
- next = (new_addr + PMD_SIZE) & PMD_MASK;
- if (extent > next - new_addr)
- extent = next - new_addr;
move_ptes(vma, old_pmd, old_addr, old_addr + extent, new_vma,
new_pmd, new_addr, need_rmap_locks);
}
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-07-08 1:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 1:24 [Patch v3 0/4] mm/mremap: cleanup move_page_tables() a little Wei Yang
2020-07-08 1:24 ` [Patch v3 1/4] mm/mremap: it is sure to have enough space when extent meets requirement Wei Yang
2020-07-08 1:24 ` Wei Yang [this message]
2020-07-08 1:24 ` [Patch v3 3/4] mm/mremap: start addresses are properly aligned Wei Yang
2020-07-08 1:24 ` [Patch v3 4/4] mm/mremap: use pmd_addr_end to simplify the calculate of extent Wei Yang
2020-07-08 8:27 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708012453.36588-3-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=anshuman.khandual@arm.com \
--cc=digetx@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=thellstrom@vmware.com \
--cc=thomas_os@shipmail.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).