From: Masami Hiramatsu <mhiramat@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Oleg Nesterov <oleg@redhat.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, mhiramat@kernel.org,
Andi Kleen <andi@firstfloor.org>, Andi Kleen <ak@linux.intel.com>
Subject: [PATCH 3/4] perf-probe: Fix memory leakage when the probe point is not found
Date: Thu, 9 Jul 2020 17:07:22 +0900 [thread overview]
Message-ID: <159428204201.56570.8191554031198604445.stgit@devnote2> (raw)
In-Reply-To: <159428201109.56570.3802208017109058146.stgit@devnote2>
Fix the memory leakage in debuginfo__find_trace_events() when the probe
point is not found in the debuginfo. If there is no probe point found in
the debuginfo, debuginfo__find_probes() will NOT return -ENOENT, but 0.
Thus the caller of debuginfo__find_probes() must check the tf.ntevs and
release the allocated memory for the array of struct probe_trace_event.
The current code releases the memory only if the debuginfo__find_probes()
hits an error but not checks tf.ntevs. In the result, the memory allocated
on *tevs are not released if tf.ntevs == 0.
This fixes the memory leakage by checking tf.ntevs == 0 in addition to
ret < 0.
Fixes: ff741783506c ("perf probe: Introduce debuginfo to encapsulate dwarf information")
Cc: stable@vger.kernel.org
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
tools/perf/util/probe-finder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index 9963e4e8ea20..659024342e9a 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -1467,7 +1467,7 @@ int debuginfo__find_trace_events(struct debuginfo *dbg,
if (ret >= 0 && tf.pf.skip_empty_arg)
ret = fill_empty_trace_arg(pev, tf.tevs, tf.ntevs);
- if (ret < 0) {
+ if (ret < 0 || tf.ntevs == 0) {
for (i = 0; i < tf.ntevs; i++)
clear_probe_trace_event(&tf.tevs[i]);
zfree(tevs);
next prev parent reply other threads:[~2020-07-09 8:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 8:06 [PATCH 0/4] perf-probe: Fix GNU IFUNC probe issue etc Masami Hiramatsu
2020-07-09 8:07 ` [PATCH 1/4] perf-probe: Avoid setting probes on same address on same event Masami Hiramatsu
2020-07-10 11:18 ` Srikar Dronamraju
2020-07-10 12:14 ` Masami Hiramatsu
2020-07-09 8:07 ` [PATCH 2/4] perf-probe: Fix wrong variable warning when the probe point is not found Masami Hiramatsu
2020-07-09 14:37 ` Andi Kleen
2020-07-10 11:16 ` Srikar Dronamraju
2020-07-09 8:07 ` Masami Hiramatsu [this message]
2020-07-10 11:16 ` [PATCH 3/4] perf-probe: Fix memory leakage " Srikar Dronamraju
2020-07-09 8:07 ` [PATCH 4/4] perf-probe: Warn if the target function is GNU Indirect function Masami Hiramatsu
2020-07-09 14:36 ` Andi Kleen
2020-07-10 3:30 ` Masami Hiramatsu
2020-07-10 11:55 ` Arnaldo Carvalho de Melo
2020-07-10 12:56 ` Masami Hiramatsu
2020-07-10 11:15 ` Srikar Dronamraju
2020-07-10 12:14 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159428204201.56570.8191554031198604445.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=acme@kernel.org \
--cc=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=srikar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).