From: <nicolas.ferre@microchip.com>
To: <linux@armlinux.org.uk>, <linux-arm-kernel@lists.infradead.org>,
<netdev@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
<harini.katakam@xilinx.com>, <f.fainelli@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
<antoine.tenart@bootlin.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>
Subject: [PATCH v5 4/5] net: macb: fix macb_suspend() by removing call to netif_carrier_off()
Date: Fri, 10 Jul 2020 14:46:44 +0200 [thread overview]
Message-ID: <a7eb7eb11da8b4e4326d86e30e4110872ac987c6.1594384335.git.nicolas.ferre@microchip.com> (raw)
In-Reply-To: <cover.1594384335.git.nicolas.ferre@microchip.com>
From: Nicolas Ferre <nicolas.ferre@microchip.com>
As we now use the phylink call to phylink_stop() in the non-WoL path,
there is no need for this call to netif_carrier_off() anymore. It can
disturb the underlying phylink FSM.
Fixes: 7897b071ac3b ("net: macb: convert to phylink")
Cc: Claudiu Beznea <claudiu.beznea@microchip.com>
Cc: Harini Katakam <harini.katakam@xilinx.com>
Cc: Antoine Tenart <antoine.tenart@bootlin.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Nicolas Ferre <nicolas.ferre@microchip.com>
---
Changes in v2:
- new in v2 serries
drivers/net/ethernet/cadence/macb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c
index 79c2fe054303..548815255e22 100644
--- a/drivers/net/ethernet/cadence/macb_main.c
+++ b/drivers/net/ethernet/cadence/macb_main.c
@@ -4604,7 +4604,6 @@ static int __maybe_unused macb_suspend(struct device *dev)
bp->pm_data.scrt2 = gem_readl_n(bp, ETHT, SCRT2_ETHT);
}
- netif_carrier_off(netdev);
if (bp->ptp_info)
bp->ptp_info->ptp_remove(netdev);
pm_runtime_force_suspend(dev);
--
2.27.0
next prev parent reply other threads:[~2020-07-10 12:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-10 12:46 [PATCH v5 0/5] net: macb: Wake-on-Lan magic packet fixes and GEM handling nicolas.ferre
2020-07-10 12:46 ` [PATCH v5 1/5] net: macb: fix wakeup test in runtime suspend/resume routines nicolas.ferre
2020-07-10 12:46 ` [PATCH v5 2/5] net: macb: mark device wake capable when "magic-packet" property present nicolas.ferre
2020-07-10 12:46 ` [PATCH v5 3/5] net: macb: fix macb_get/set_wol() when moving to phylink nicolas.ferre
2020-07-10 12:46 ` nicolas.ferre [this message]
2020-07-10 12:46 ` [PATCH v5 5/5] net: macb: fix call to pm_runtime in the suspend/resume functions nicolas.ferre
2020-07-10 21:29 ` [PATCH v5 0/5] net: macb: Wake-on-Lan magic packet fixes and GEM handling David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7eb7eb11da8b4e4326d86e30e4110872ac987c6.1594384335.git.nicolas.ferre@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=claudiu.beznea@microchip.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=harini.katakam@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).