From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: rostedt@goodmis.org, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [Patch v2 1/4] tracing: simplify the logic by defining next to be "lasst + 1"
Date: Sun, 12 Jul 2020 09:10:33 +0800 [thread overview]
Message-ID: <20200712011036.70948-2-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200712011036.70948-1-richard.weiyang@linux.alibaba.com>
The value to be used and compared in trace_search_list() is "last + 1".
Let's just define next to be "last + 1" instead of doing the addition
each time.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
---
kernel/trace/trace_output.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/kernel/trace/trace_output.c b/kernel/trace/trace_output.c
index 73976de7f8cc..a35232d61601 100644
--- a/kernel/trace/trace_output.c
+++ b/kernel/trace/trace_output.c
@@ -675,11 +675,11 @@ static LIST_HEAD(ftrace_event_list);
static int trace_search_list(struct list_head **list)
{
struct trace_event *e;
- int last = __TRACE_LAST_TYPE;
+ int next = __TRACE_LAST_TYPE + 1;
if (list_empty(&ftrace_event_list)) {
*list = &ftrace_event_list;
- return last + 1;
+ return next;
}
/*
@@ -687,17 +687,17 @@ static int trace_search_list(struct list_head **list)
* lets see if somebody freed one.
*/
list_for_each_entry(e, &ftrace_event_list, list) {
- if (e->type != last + 1)
+ if (e->type != next)
break;
- last++;
+ next++;
}
/* Did we used up all 65 thousand events??? */
- if ((last + 1) > TRACE_EVENT_TYPE_MAX)
+ if (next > TRACE_EVENT_TYPE_MAX)
return 0;
*list = &e->list;
- return last + 1;
+ return next;
}
void trace_event_read_lock(void)
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-07-12 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 1:10 [Patch v2 0/4] tracing: trivial cleanup Wei Yang
2020-07-12 1:10 ` Wei Yang [this message]
2020-07-12 1:10 ` [Patch v2 2/4] tracing: save one trace_event->type by using __TRACE_LAST_TYPE Wei Yang
2020-07-12 1:10 ` [Patch v2 3/4] tracing: toplevel d_entry already initialized Wei Yang
2020-07-12 1:10 ` [Patch v2 4/4] tracing: make tracing_init_dentry() returns an integer instead of a d_entry pointer Wei Yang
2020-08-28 3:42 ` [Patch v2 0/4] tracing: trivial cleanup Wei Yang
2020-09-14 22:55 ` Steven Rostedt
2020-09-15 1:32 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712011036.70948-2-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).