From: madhuparnabhowmik10@gmail.com
To: paulmck@kernel.org, josh@joshtriplett.org,
joel@joelfernandes.org, pbonzini@redhat.com
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, kvm@vger.kernel.org, frextrite@gmail.com,
Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Subject: [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage
Date: Sun, 12 Jul 2020 18:40:03 +0530 [thread overview]
Message-ID: <20200712131003.23271-2-madhuparnabhowmik10@gmail.com> (raw)
In-Reply-To: <20200712131003.23271-1-madhuparnabhowmik10@gmail.com>
From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Use hlist_for_each_entry_srcu() instead of hlist_for_each_entry_rcu()
as it also checkes if the right lock is held.
Using hlist_for_each_entry_rcu() with a condition argument will not
report the cases where a SRCU protected list is traversed using
rcu_read_lock(). Hence, use hlist_for_each_entry_srcu().
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
---
arch/x86/kvm/mmu/page_track.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kvm/mmu/page_track.c b/arch/x86/kvm/mmu/page_track.c
index a7bcde34d1f2..a9cd17625950 100644
--- a/arch/x86/kvm/mmu/page_track.c
+++ b/arch/x86/kvm/mmu/page_track.c
@@ -229,7 +229,8 @@ void kvm_page_track_write(struct kvm_vcpu *vcpu, gpa_t gpa, const u8 *new,
return;
idx = srcu_read_lock(&head->track_srcu);
- hlist_for_each_entry_rcu(n, &head->track_notifier_list, node)
+ hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
+ srcu_read_lock_held(&head->track_srcu))
if (n->track_write)
n->track_write(vcpu, gpa, new, bytes, n);
srcu_read_unlock(&head->track_srcu, idx);
@@ -254,7 +255,8 @@ void kvm_page_track_flush_slot(struct kvm *kvm, struct kvm_memory_slot *slot)
return;
idx = srcu_read_lock(&head->track_srcu);
- hlist_for_each_entry_rcu(n, &head->track_notifier_list, node)
+ hlist_for_each_entry_srcu(n, &head->track_notifier_list, node,
+ srcu_read_lock_held(&head->track_srcu))
if (n->track_flush_slot)
n->track_flush_slot(kvm, slot, n);
srcu_read_unlock(&head->track_srcu, idx);
--
2.17.1
next prev parent reply other threads:[~2020-07-12 13:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-12 13:10 [PATCH 1/2] rculist : Introduce list/hlist_for_each_entry_srcu() macros madhuparnabhowmik10
2020-07-12 13:10 ` madhuparnabhowmik10 [this message]
2020-07-12 16:08 ` [PATCH 2/2] kvm: mmu: page_track: Fix RCU list API usage Paul E. McKenney
2020-07-16 14:44 ` Naresh Kamboju
2020-07-17 0:19 ` Dexuan-Linux Cui
2020-07-17 17:07 ` Paul E. McKenney
2020-07-17 18:03 ` Daniel Díaz
2020-07-17 18:25 ` Daniel Díaz
2020-07-17 19:05 ` Naresh Kamboju
2020-07-18 0:12 ` Paul E. McKenney
2020-07-19 12:22 ` Naresh Kamboju
2020-07-19 16:08 ` Paul E. McKenney
2020-07-20 14:13 ` Naresh Kamboju
2020-07-20 23:31 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200712131003.23271-2-madhuparnabhowmik10@gmail.com \
--to=madhuparnabhowmik10@gmail.com \
--cc=frextrite@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rcu@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).