From: Alexey Budankov <alexey.budankov@linux.intel.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Andi Kleen <ak@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH v11 10/15] perf stat: extend -D,--delay option with -1 value
Date: Tue, 14 Jul 2020 12:09:21 +0300 [thread overview]
Message-ID: <ecc41d13-a5c1-d5b2-539f-8608d549e1c5@linux.intel.com> (raw)
In-Reply-To: <037d737f-0ada-a9f0-9686-f7521ca6fbc3@linux.intel.com>
Extend -D,--delay option with -1 value to start monitoring with
events disabled to be enabled later by enable command provided
via control file descriptor.
Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
---
tools/perf/Documentation/perf-stat.txt | 5 +++--
tools/perf/builtin-stat.c | 18 ++++++++++++++----
tools/perf/util/evlist.h | 3 +++
tools/perf/util/stat.h | 2 +-
4 files changed, 21 insertions(+), 7 deletions(-)
diff --git a/tools/perf/Documentation/perf-stat.txt b/tools/perf/Documentation/perf-stat.txt
index b029ee728a0b..9f32f6cd558d 100644
--- a/tools/perf/Documentation/perf-stat.txt
+++ b/tools/perf/Documentation/perf-stat.txt
@@ -238,8 +238,9 @@ mode, use --per-node in addition to -a. (system-wide).
-D msecs::
--delay msecs::
-After starting the program, wait msecs before measuring. This is useful to
-filter out the startup phase of the program, which is often very different.
+After starting the program, wait msecs before measuring (-1: start with events
+disabled). This is useful to filter out the startup phase of the program,
+which is often very different.
-T::
--transaction::
diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index a5a0f4841003..9d5c503e698f 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -487,16 +487,26 @@ static bool handle_interval(unsigned int interval, int *times)
static void enable_counters(void)
{
- if (stat_config.initial_delay)
+ if (stat_config.initial_delay < 0) {
+ pr_info(EVLIST_DISABLED_MSG);
+ return;
+ }
+
+ if (stat_config.initial_delay > 0) {
+ pr_info(EVLIST_DISABLED_MSG);
usleep(stat_config.initial_delay * USEC_PER_MSEC);
+ }
/*
* We need to enable counters only if:
* - we don't have tracee (attaching to task or cpu)
* - we have initial delay configured
*/
- if (!target__none(&target) || stat_config.initial_delay)
+ if (!target__none(&target) || stat_config.initial_delay) {
evlist__enable(evsel_list);
+ if (stat_config.initial_delay > 0)
+ pr_info(EVLIST_ENABLED_MSG);
+ }
}
static void disable_counters(void)
@@ -1053,8 +1063,8 @@ static struct option stat_options[] = {
"aggregate counts per thread", AGGR_THREAD),
OPT_SET_UINT(0, "per-node", &stat_config.aggr_mode,
"aggregate counts per numa node", AGGR_NODE),
- OPT_UINTEGER('D', "delay", &stat_config.initial_delay,
- "ms to wait before starting measurement after program start"),
+ OPT_INTEGER('D', "delay", &stat_config.initial_delay,
+ "ms to wait before starting measurement after program start (-1: start with events disabled)"),
OPT_CALLBACK_NOOPT(0, "metric-only", &stat_config.metric_only, NULL,
"Only print computed metrics. No raw values", enable_metric_only),
OPT_BOOLEAN(0, "metric-no-group", &stat_config.metric_no_group,
diff --git a/tools/perf/util/evlist.h b/tools/perf/util/evlist.h
index cc628798734d..8ee12c1f0526 100644
--- a/tools/perf/util/evlist.h
+++ b/tools/perf/util/evlist.h
@@ -377,4 +377,7 @@ int evlist__finalize_ctlfd(struct evlist *evlist);
bool evlist__ctlfd_initialized(struct evlist *evlist);
int evlist__ctlfd_process(struct evlist *evlist, enum evlist_ctl_cmd *cmd);
+#define EVLIST_ENABLED_MSG "Events enabled\n"
+#define EVLIST_DISABLED_MSG "Events disabled\n"
+
#endif /* __PERF_EVLIST_H */
diff --git a/tools/perf/util/stat.h b/tools/perf/util/stat.h
index 6911c7249199..41d59f192931 100644
--- a/tools/perf/util/stat.h
+++ b/tools/perf/util/stat.h
@@ -116,7 +116,7 @@ struct perf_stat_config {
FILE *output;
unsigned int interval;
unsigned int timeout;
- unsigned int initial_delay;
+ int initial_delay;
unsigned int unit_width;
unsigned int metric_only_len;
int times;
--
2.24.1
next prev parent reply other threads:[~2020-07-14 9:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 8:37 [PATCH v11 00/15] perf: support enable and disable commands in stat and record modes Alexey Budankov
2020-07-14 9:03 ` [PATCH v11 01/15] tools/libperf: avoid internal moving of fdarray fds Alexey Budankov
2020-07-14 9:03 ` [PATCH v11 02/15] tools/libperf: add flags to fdarray fds objects Alexey Budankov
2020-07-14 9:04 ` [PATCH v11 03/15] tools/libperf: avoid counting of nonfilterable fdarray fds Alexey Budankov
2020-07-16 8:34 ` [tools/libperf] 8edd7f4133: perf-sanity-tests.Filter_fds_with_revents_mask_in_a_fdarray.fail kernel test robot
2020-07-16 15:20 ` Arnaldo Carvalho de Melo
2020-07-16 16:09 ` Alexey Budankov
2020-07-16 16:50 ` Arnaldo Carvalho de Melo
2020-07-14 9:05 ` [PATCH v11 04/15] perf evlist: introduce control file descriptors Alexey Budankov
2020-07-14 9:05 ` [PATCH v11 05/15] perf evlist: implement control command handling functions Alexey Budankov
2020-07-14 9:06 ` [PATCH v11 06/15] perf stat: factor out body of event handling loop for system wide Alexey Budankov
2020-07-14 9:07 ` [PATCH v11 07/15] perf stat: move target check to loop control statement Alexey Budankov
2020-07-14 9:07 ` [PATCH v11 08/15] perf stat: factor out body of event handling loop for fork case Alexey Budankov
2020-07-14 9:08 ` [PATCH v11 09/15] perf stat: factor out event handling loop into dispatch_events() Alexey Budankov
2020-07-14 9:09 ` Alexey Budankov [this message]
2020-07-14 9:09 ` [PATCH v11 11/15] perf stat: implement control commands handling Alexey Budankov
2020-07-14 9:10 ` [PATCH v11 12/15] perf stat: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-07-14 9:11 ` [PATCH v11 13/15] perf record: extend -D,--delay option with -1 value Alexey Budankov
2020-07-14 9:11 ` [PATCH v11 14/15] perf record: implement control commands handling Alexey Budankov
2020-07-14 9:12 ` [PATCH v11 15/15] perf record: introduce --control fd:ctl-fd[,ack-fd] options Alexey Budankov
2020-07-14 12:05 ` [PATCH v11 00/15] perf: support enable and disable commands in stat and record modes Namhyung Kim
2020-07-14 15:16 ` Arnaldo Carvalho de Melo
2020-07-14 15:53 ` Alexey Budankov
2020-07-14 16:15 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ecc41d13-a5c1-d5b2-539f-8608d549e1c5@linux.intel.com \
--to=alexey.budankov@linux.intel.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).