[V3] staging: rtl8723bs: core: Using comparison to true is error prone
diff mbox series

Message ID 20200725143712.16667-1-john.oldman@polehill.co.uk
State New
Headers show
Series
  • [V3] staging: rtl8723bs: core: Using comparison to true is error prone
Related show

Commit Message

John Oldman July 25, 2020, 2:37 p.m. UTC
clear below issues reported by checkpatch.pl:

CHECK: Using comparison to true is error prone

Signed-off-by: John Oldman <john.oldman@polehill.co.uk>
---
v1- First attempt: removed comparison to true.
v2- Removed unneccessary parentheses around 'pregistrypriv->ht_enable, missed in v1.
v3- Corrected the 'odd' subject line; moved the || and && to the end of the line.

 drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

--
2.17.1

Comments

Greg KH July 25, 2020, 5:21 p.m. UTC | #1
On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote:
> clear below issues reported by checkpatch.pl:
> 
> CHECK: Using comparison to true is error prone

Again, you did more than just this in the patch :(
John Oldman July 25, 2020, 5:36 p.m. UTC | #2
On Sat, Jul 25, 2020 at 07:21:24PM +0200, Greg KH wrote:
> On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote:
> > clear below issues reported by checkpatch.pl:
> > 
> > CHECK: Using comparison to true is error prone
> 
> Again, you did more than just this in the patch :(

do you mean by reducing line lengths??

Patch
diff mbox series

diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
index ca98274ae390..46fad71197b6 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
@@ -363,8 +363,9 @@  int rtw_generate_ie(struct registry_priv *pregistrypriv)
 	}

 	/* HT Cap. */
-	if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N))
-		&& (pregistrypriv->ht_enable == true)) {
+	if (((pregistrypriv->wireless_mode & WIRELESS_11_5N) ||
+	     (pregistrypriv->wireless_mode & WIRELESS_11_24N)) &&
+	     pregistrypriv->ht_enable) {
 		/* todo: */
 	}