[2/2] locking/qspinlock: Do not include atomic.h from qspinlock_types.h
diff mbox series

Message ID 20200729123316.GC7047@gondor.apana.org.au
State New, archived
Headers show
  • locking/qspinlock: Break qspinlock_types.h header loop
Related show

Commit Message

Herbert Xu July 29, 2020, 12:33 p.m. UTC
This patch breaks a header loop involving qspinlock_types.h.
The issue is that qspinlock_types.h includes atomic.h, which then
eventually includes kernel.h which could lead back to the original
file via spinlock_types.h.

As ATOMIC_INIT is now defined by linux/types.h, there is no longer
any need to include atomic.h from qspinlock_types.h.  This also
allows the CONFIG_PARAVIRT hack to be removed since it was trying
to prevent exactly this loop.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff mbox series

diff --git a/include/asm-generic/qspinlock.h b/include/asm-generic/qspinlock.h
index 38ca14e79a86..4fe7fd0fe834 100644
--- a/include/asm-generic/qspinlock.h
+++ b/include/asm-generic/qspinlock.h
@@ -11,6 +11,7 @@ 
 #include <asm-generic/qspinlock_types.h>
+#include <linux/atomic.h>
 #ifndef queued_spin_is_locked
diff --git a/include/asm-generic/qspinlock_types.h b/include/asm-generic/qspinlock_types.h
index 56d1309d32f8..2fd1fb89ec36 100644
--- a/include/asm-generic/qspinlock_types.h
+++ b/include/asm-generic/qspinlock_types.h
@@ -9,15 +9,7 @@ 
- * Including atomic.h with PARAVIRT on will cause compilation errors because
- * of recursive header file incluson via paravirt_types.h. So don't include
- * it if PARAVIRT is on.
- */
 #include <linux/types.h>
-#include <linux/atomic.h>
 typedef struct qspinlock {
 	union {