ieee802154/adf7242: check status of adf7242_read_reg
diff mbox series

Message ID 20200802142339.21091-1-trix@redhat.com
State Accepted
Commit e3914ed6cf44bfe1f169e26241f8314556fd1ac1
Headers show
Series
  • ieee802154/adf7242: check status of adf7242_read_reg
Related show

Commit Message

Tom Rix Aug. 2, 2020, 2:23 p.m. UTC
From: Tom Rix <trix@redhat.com>

Clang static analysis reports this error

adf7242.c:887:6: warning: Assigned value is garbage or undefined
        len = len_u8;
            ^ ~~~~~~

len_u8 is set in
       adf7242_read_reg(lp, 0, &len_u8);

When this call fails, len_u8 is not set.

So check the return code.

Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154")

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/ieee802154/adf7242.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Hennerich, Michael Aug. 3, 2020, 6:20 a.m. UTC | #1
> -----Original Message-----
> From: trix@redhat.com <trix@redhat.com>
> Sent: Sonntag, 2. August 2020 16:24
> To: Hennerich, Michael <Michael.Hennerich@analog.com>;
> alex.aring@gmail.com; stefan@datenfreihafen.org; davem@davemloft.net;
> kuba@kernel.org; marcel@holtmann.org
> Cc: linux-wpan@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Tom Rix <trix@redhat.com>
> Subject: [PATCH] ieee802154/adf7242: check status of adf7242_read_reg
> 
> 
> From: Tom Rix <trix@redhat.com>
> 
> Clang static analysis reports this error
> 
> adf7242.c:887:6: warning: Assigned value is garbage or undefined
>         len = len_u8;
>             ^ ~~~~~~
> 
> len_u8 is set in
>        adf7242_read_reg(lp, 0, &len_u8);
> 
> When this call fails, len_u8 is not set.
> 
> So check the return code.
> 
> Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC
> IEEE802154")
> 
> Signed-off-by: Tom Rix <trix@redhat.com>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

> ---
>  drivers/net/ieee802154/adf7242.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/adf7242.c
> b/drivers/net/ieee802154/adf7242.c
> index c11f32f644db..7db9cbd0f5de 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp)
>  	int ret;
>  	u8 lqi, len_u8, *data;
> 
> -	adf7242_read_reg(lp, 0, &len_u8);
> +	ret = adf7242_read_reg(lp, 0, &len_u8);
> +	if (ret)
> +		return ret;
> 
>  	len = len_u8;
> 
> --
> 2.18.1
Stefan Schmidt Aug. 3, 2020, 6:27 p.m. UTC | #2
Hello.

On 02.08.20 16:23, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Clang static analysis reports this error
> 
> adf7242.c:887:6: warning: Assigned value is garbage or undefined
>          len = len_u8;
>              ^ ~~~~~~
> 
> len_u8 is set in
>         adf7242_read_reg(lp, 0, &len_u8);
> 
> When this call fails, len_u8 is not set.
> 
> So check the return code.
> 
> Fixes: 7302b9d90117 ("ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154")
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/net/ieee802154/adf7242.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
> index c11f32f644db..7db9cbd0f5de 100644
> --- a/drivers/net/ieee802154/adf7242.c
> +++ b/drivers/net/ieee802154/adf7242.c
> @@ -882,7 +882,9 @@ static int adf7242_rx(struct adf7242_local *lp)
>   	int ret;
>   	u8 lqi, len_u8, *data;
>   
> -	adf7242_read_reg(lp, 0, &len_u8);
> +	ret = adf7242_read_reg(lp, 0, &len_u8);
> +	if (ret)
> +		return ret;
>   
>   	len = len_u8;
>   
> 


This patch has been applied to the wpan tree and will be
part of the next pull request to net. Thanks!

regards
Stefan Schmidt

Patch
diff mbox series

diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
index c11f32f644db..7db9cbd0f5de 100644
--- a/drivers/net/ieee802154/adf7242.c
+++ b/drivers/net/ieee802154/adf7242.c
@@ -882,7 +882,9 @@  static int adf7242_rx(struct adf7242_local *lp)
 	int ret;
 	u8 lqi, len_u8, *data;
 
-	adf7242_read_reg(lp, 0, &len_u8);
+	ret = adf7242_read_reg(lp, 0, &len_u8);
+	if (ret)
+		return ret;
 
 	len = len_u8;