[2/9] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config
diff mbox series

Message ID 1596975355-39813-3-git-send-email-cang@codeaurora.org
State In Next
Commit 89dd87acd40a44de8ff3358138aedf8f73f4efc6
Headers show
  • [1/9] scsi: ufs: Add checks before setting clk-gating states
Related show

Commit Message

Can Guo Aug. 9, 2020, 12:15 p.m. UTC
If ufs_qcom_dump_dbg_regs() calls ufs_qcom_testbus_config() from
ufshcd_suspend/resume and/or clk gate/ungate context, pm_runtime_get_sync()
and ufshcd_hold() will cause racing problems. Fix this by removing the
unnecessary calls of pm_runtime_get_sync() and ufshcd_hold().

Signed-off-by: Can Guo <cang@codeaurora.org>
Reviewed-by: Hongwu Su <hongwus@codeaurora.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>
Reviewed-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>

diff mbox series

diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
index d0d7552..823eccf 100644
--- a/drivers/scsi/ufs/ufs-qcom.c
+++ b/drivers/scsi/ufs/ufs-qcom.c
@@ -1614,9 +1614,6 @@  int ufs_qcom_testbus_config(struct ufs_qcom_host *host)
 	mask <<= offset;
-	pm_runtime_get_sync(host->hba->dev);
-	ufshcd_hold(host->hba, false);
 	ufshcd_rmwl(host->hba, TEST_BUS_SEL,
 		    (u32)host->testbus.select_major << 19,
@@ -1629,8 +1626,6 @@  int ufs_qcom_testbus_config(struct ufs_qcom_host *host)
 	 * committed before returning.
-	ufshcd_release(host->hba);
-	pm_runtime_put_sync(host->hba->dev);
 	return 0;