usb: gadget: f_tcm: Fix some resource leaks in some error paths
diff mbox series

Message ID
State Accepted
Commit 07c8434150f4eb0b65cae288721c8af1080fde17
Headers show
  • usb: gadget: f_tcm: Fix some resource leaks in some error paths
Related show

Commit Message

Christophe JAILLET Aug. 14, 2020, 5:55 a.m. UTC
If a memory allocation fails within a 'usb_ep_alloc_request()' call, the
already allocated memory must be released.

Fix a mix-up in the code and free the correct requests.

Fixes: c52661d60f63 ("usb-gadget: Initial merge of target module for UASP + BOT")
Signed-off-by: Christophe JAILLET <>
 drivers/usb/gadget/function/f_tcm.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff mbox series

diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
index d94b814328c8..184165e27908 100644
--- a/drivers/usb/gadget/function/f_tcm.c
+++ b/drivers/usb/gadget/function/f_tcm.c
@@ -753,12 +753,13 @@  static int uasp_alloc_stream_res(struct f_uas *fu, struct uas_stream *stream)
 		goto err_sts;
 	return 0;
-	usb_ep_free_request(fu->ep_status, stream->req_status);
-	stream->req_status = NULL;
 	usb_ep_free_request(fu->ep_out, stream->req_out);
 	stream->req_out = NULL;
+	usb_ep_free_request(fu->ep_in, stream->req_in);
+	stream->req_in = NULL;
 	return -ENOMEM;