From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: alexander.h.duyck@linux.intel.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [PATCH] mm/page_reporting: the "page" must not be the list head
Date: Mon, 17 Aug 2020 16:48:36 +0800 [thread overview]
Message-ID: <20200817084836.29216-1-richard.weiyang@linux.alibaba.com> (raw)
If "page" is the list head, list_for_each_entry_safe() would stop
iteration.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
---
mm/page_reporting.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_reporting.c b/mm/page_reporting.c
index 3bbd471cfc81..aaaa3605123d 100644
--- a/mm/page_reporting.c
+++ b/mm/page_reporting.c
@@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
* the new head of the free list before we release the
* zone lock.
*/
- if (&page->lru != list && !list_is_first(&page->lru, list))
+ if (!list_is_first(&page->lru, list))
list_rotate_to_front(&page->lru, list);
/* release lock before waiting on report processing */
--
2.20.1 (Apple Git-117)
next reply other threads:[~2020-08-17 8:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:48 Wei Yang [this message]
2020-08-17 9:35 ` [PATCH] mm/page_reporting: the "page" must not be the list head David Hildenbrand
2020-08-17 16:05 ` Alexander Duyck
2020-08-17 17:07 ` David Hildenbrand
2020-08-18 3:05 ` Wei Yang
2020-08-18 7:23 ` David Hildenbrand
2020-08-18 8:41 ` Wei Yang
2020-08-18 3:22 ` Wei Yang
2020-08-18 14:58 ` Alexander Duyck
2020-08-18 3:03 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817084836.29216-1-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).