From: Allen Pais <allen.cryptic@gmail.com>
To: perex@perex.cz, tiwai@suse.com, clemens@ladisch.de,
o-takashi@sakamocchi.jp, timur@kernel.org,
nicoleotsuka@gmail.com, Xiubo.Lee@gmail.com
Cc: keescook@chromium.org, alsa-devel@alsa-project.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Allen Pais <allen.lkml@gmail.com>,
Romain Perier <romain.perier@gmail.com>
Subject: [PATCH 07/10] sound/soc: sh: convert tasklets to use new tasklet_setup() API
Date: Mon, 17 Aug 2020 14:27:00 +0530 [thread overview]
Message-ID: <20200817085703.25732-8-allen.cryptic@gmail.com> (raw)
In-Reply-To: <20200817085703.25732-1-allen.cryptic@gmail.com>
From: Allen Pais <allen.lkml@gmail.com>
In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.
Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
sound/soc/sh/siu_pcm.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/sound/soc/sh/siu_pcm.c b/sound/soc/sh/siu_pcm.c
index bd9de77c35f3..50fc7810723e 100644
--- a/sound/soc/sh/siu_pcm.c
+++ b/sound/soc/sh/siu_pcm.c
@@ -198,9 +198,9 @@ static int siu_pcm_rd_set(struct siu_port *port_info,
return 0;
}
-static void siu_io_tasklet(unsigned long data)
+static void siu_io_tasklet(struct tasklet_struct *t)
{
- struct siu_stream *siu_stream = (struct siu_stream *)data;
+ struct siu_stream *siu_stream = from_tasklet(siu_stream, t, tasklet);
struct snd_pcm_substream *substream = siu_stream->substream;
struct device *dev = substream->pcm->card->dev;
struct snd_pcm_runtime *rt = substream->runtime;
@@ -520,10 +520,8 @@ static int siu_pcm_new(struct snd_soc_component *component,
(*port_info)->pcm = pcm;
/* IO tasklets */
- tasklet_init(&(*port_info)->playback.tasklet, siu_io_tasklet,
- (unsigned long)&(*port_info)->playback);
- tasklet_init(&(*port_info)->capture.tasklet, siu_io_tasklet,
- (unsigned long)&(*port_info)->capture);
+ tasklet_setup(&(*port_info)->playback.tasklet, siu_io_tasklet);
+ tasklet_setup(&(*port_info)->capture.tasklet, siu_io_tasklet);
}
dev_info(card->dev, "SuperH SIU driver initialized.\n");
--
2.17.1
next prev parent reply other threads:[~2020-08-17 8:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 8:56 [PATCH 00/10] sound: convert tasklets to use new tasklet_setup() Allen Pais
2020-08-17 8:56 ` [PATCH 01/10] sound: core: convert tasklets to use new tasklet_setup() API Allen Pais
2020-08-17 8:56 ` [PATCH 02/10] sound: firewire: " Allen Pais
2020-08-17 8:56 ` [PATCH 03/10] sound: asihpi: " Allen Pais
2020-08-17 8:56 ` [PATCH 04/10] sound: riptide: " Allen Pais
2020-08-17 8:56 ` [PATCH 05/10] sound: rm9652: " Allen Pais
2020-08-17 8:56 ` [PATCH 06/10] sound/soc: fsl_esai: " Allen Pais
2020-08-17 8:57 ` Allen Pais [this message]
2020-08-17 8:57 ` [PATCH 08/10] sound/soc: txx9: " Allen Pais
2020-08-17 8:57 ` [PATCH 09/10] sound: midi: " Allen Pais
2020-08-17 8:57 ` [PATCH 10/10] sound: ua101: " Allen Pais
2020-08-17 9:08 ` [PATCH 00/10] sound: convert tasklets to use new tasklet_setup() Takashi Iwai
2020-08-17 9:18 ` Allen Pais
2020-08-17 9:43 ` Takashi Iwai
2020-08-18 9:31 ` Allen
2020-08-18 10:25 ` Takashi Iwai
2020-08-18 10:44 ` Mark Brown
2020-08-18 10:59 ` Takashi Iwai
2020-08-19 10:51 ` Allen
2020-08-19 11:16 ` Mark Brown
2020-08-19 11:28 ` Takashi Iwai
2020-09-01 10:04 ` Allen
2020-09-01 10:09 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817085703.25732-8-allen.cryptic@gmail.com \
--to=allen.cryptic@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=romain.perier@gmail.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).