From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
James Clark <james.clark@arm.com>, Will Deacon <will@kernel.org>,
Al Grant <Al.Grant@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Wei Li <liwei391@huawei.com>,
linux-kernel@vger.kernel.org,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Mike Leach <mike.leach@linaro.org>
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH RESEND v1 09/13] perf arm-spe: Refactor event type handling
Date: Mon, 17 Aug 2020 15:53:44 +0100 [thread overview]
Message-ID: <20200817145348.14461-10-leo.yan@linaro.org> (raw)
In-Reply-To: <20200817145348.14461-1-leo.yan@linaro.org>
Use macros instead of the enum values for event types, this is more
directive and without bit shifting when parse packet.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
.../util/arm-spe-decoder/arm-spe-decoder.c | 16 +++++++-------
.../util/arm-spe-decoder/arm-spe-decoder.h | 17 --------------
.../arm-spe-decoder/arm-spe-pkt-decoder.c | 22 +++++++++----------
.../arm-spe-decoder/arm-spe-pkt-decoder.h | 16 ++++++++++++++
4 files changed, 35 insertions(+), 36 deletions(-)
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
index f7cda4a3cf1a..ae718e3419e3 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
@@ -168,31 +168,31 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
case ARM_SPE_OP_TYPE:
break;
case ARM_SPE_EVENTS:
- if (payload & BIT(EV_L1D_REFILL))
+ if (payload & SPE_EVT_PKT_L1D_REFILL)
decoder->record.type |= ARM_SPE_L1D_MISS;
- if (payload & BIT(EV_L1D_ACCESS))
+ if (payload & SPE_EVT_PKT_L1D_ACCESS)
decoder->record.type |= ARM_SPE_L1D_ACCESS;
- if (payload & BIT(EV_TLB_WALK))
+ if (payload & SPE_EVT_PKT_TLB_WALK)
decoder->record.type |= ARM_SPE_TLB_MISS;
- if (payload & BIT(EV_TLB_ACCESS))
+ if (payload & SPE_EVT_PKT_TLB_ACCESS)
decoder->record.type |= ARM_SPE_TLB_ACCESS;
if ((idx == 2 || idx == 4 || idx == 8) &&
- (payload & BIT(EV_LLC_MISS)))
+ (payload & SPE_EVT_PKT_LLC_MISS))
decoder->record.type |= ARM_SPE_LLC_MISS;
if ((idx == 2 || idx == 4 || idx == 8) &&
- (payload & BIT(EV_LLC_ACCESS)))
+ (payload & SPE_EVT_PKT_LLC_ACCESS))
decoder->record.type |= ARM_SPE_LLC_ACCESS;
if ((idx == 2 || idx == 4 || idx == 8) &&
- (payload & BIT(EV_REMOTE_ACCESS)))
+ (payload & SPE_EVT_PKT_REMOTE_ACCESS))
decoder->record.type |= ARM_SPE_REMOTE_ACCESS;
- if (payload & BIT(EV_MISPRED))
+ if (payload & SPE_EVT_PKT_MISPREDICTED)
decoder->record.type |= ARM_SPE_BRANCH_MISS;
break;
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
index a5111a8d4360..24727b8ca7ff 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.h
@@ -13,23 +13,6 @@
#include "arm-spe-pkt-decoder.h"
-enum arm_spe_events {
- EV_EXCEPTION_GEN = 0,
- EV_RETIRED = 1,
- EV_L1D_ACCESS = 2,
- EV_L1D_REFILL = 3,
- EV_TLB_ACCESS = 4,
- EV_TLB_WALK = 5,
- EV_NOT_TAKEN = 6,
- EV_MISPRED = 7,
- EV_LLC_ACCESS = 8,
- EV_LLC_MISS = 9,
- EV_REMOTE_ACCESS = 10,
- EV_ALIGNMENT = 11,
- EV_PARTIAL_PREDICATE = 17,
- EV_EMPTY_PREDICATE = 18,
-};
-
enum arm_spe_sample_type {
ARM_SPE_L1D_ACCESS = 1 << 0,
ARM_SPE_L1D_MISS = 1 << 1,
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
index 6cb14a2141c4..78250c8d74ca 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.c
@@ -264,58 +264,58 @@ int arm_spe_pkt_desc(const struct arm_spe_pkt *packet, char *buf,
ret = snprintf(buf, buf_len, "EV");
buf += ret;
blen -= ret;
- if (payload & 0x1) {
+ if (payload & SPE_EVT_PKT_GEN_EXCEPTION) {
ret = snprintf(buf, buf_len, " EXCEPTION-GEN");
buf += ret;
blen -= ret;
}
- if (payload & 0x2) {
+ if (payload & SPE_EVT_PKT_ARCH_RETIRED) {
ret = snprintf(buf, buf_len, " RETIRED");
buf += ret;
blen -= ret;
}
- if (payload & 0x4) {
+ if (payload & SPE_EVT_PKT_L1D_ACCESS) {
ret = snprintf(buf, buf_len, " L1D-ACCESS");
buf += ret;
blen -= ret;
}
- if (payload & 0x8) {
+ if (payload & SPE_EVT_PKT_L1D_REFILL) {
ret = snprintf(buf, buf_len, " L1D-REFILL");
buf += ret;
blen -= ret;
}
- if (payload & 0x10) {
+ if (payload & SPE_EVT_PKT_TLB_ACCESS) {
ret = snprintf(buf, buf_len, " TLB-ACCESS");
buf += ret;
blen -= ret;
}
- if (payload & 0x20) {
+ if (payload & SPE_EVT_PKT_TLB_WALK) {
ret = snprintf(buf, buf_len, " TLB-REFILL");
buf += ret;
blen -= ret;
}
- if (payload & 0x40) {
+ if (payload & SPE_EVT_PKT_NOT_TAKEN) {
ret = snprintf(buf, buf_len, " NOT-TAKEN");
buf += ret;
blen -= ret;
}
- if (payload & 0x80) {
+ if (payload & SPE_EVT_PKT_MISPREDICTED) {
ret = snprintf(buf, buf_len, " MISPRED");
buf += ret;
blen -= ret;
}
if (idx > 1) {
- if (payload & 0x100) {
+ if (payload & SPE_EVT_PKT_LLC_ACCESS) {
ret = snprintf(buf, buf_len, " LLC-ACCESS");
buf += ret;
blen -= ret;
}
- if (payload & 0x200) {
+ if (payload & SPE_EVT_PKT_LLC_MISS) {
ret = snprintf(buf, buf_len, " LLC-REFILL");
buf += ret;
blen -= ret;
}
- if (payload & 0x400) {
+ if (payload & SPE_EVT_PKT_REMOTE_ACCESS) {
ret = snprintf(buf, buf_len, " REMOTE-ACCESS");
buf += ret;
blen -= ret;
diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
index ee2c1d5054e8..16687abffab7 100644
--- a/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
+++ b/tools/perf/util/arm-spe-decoder/arm-spe-pkt-decoder.h
@@ -93,6 +93,22 @@ struct arm_spe_pkt {
#define SPE_CNT_PKT_HDR_EXT_INDEX_MASK (0x3)
+/* Event packet payload */
+#define SPE_EVT_PKT_SVE_EMPTY_PREDICATE BIT(18)
+#define SPE_EVT_PKT_SVE_PARTIAL_PREDICATE BIT(17)
+#define SPE_EVT_PKT_ALIGNMENT BIT(11)
+#define SPE_EVT_PKT_REMOTE_ACCESS BIT(10)
+#define SPE_EVT_PKT_LLC_MISS BIT(9)
+#define SPE_EVT_PKT_LLC_ACCESS BIT(8)
+#define SPE_EVT_PKT_MISPREDICTED BIT(7)
+#define SPE_EVT_PKT_NOT_TAKEN BIT(6)
+#define SPE_EVT_PKT_TLB_WALK BIT(5)
+#define SPE_EVT_PKT_TLB_ACCESS BIT(4)
+#define SPE_EVT_PKT_L1D_REFILL BIT(3)
+#define SPE_EVT_PKT_L1D_ACCESS BIT(2)
+#define SPE_EVT_PKT_ARCH_RETIRED BIT(1)
+#define SPE_EVT_PKT_GEN_EXCEPTION BIT(0)
+
const char *arm_spe_pkt_name(enum arm_spe_pkt_type);
int arm_spe_get_packet(const unsigned char *buf, size_t len,
--
2.17.1
next prev parent reply other threads:[~2020-08-17 14:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 14:53 [PATCH RESEND v1 00/13] perf arm-spe: Refactor decoding & dumping flow Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 01/13] perf arm-spe: Include bitops.h for BIT() macro Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 02/13] perf arm-spe: Fix a typo in comment Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 03/13] perf arm-spe: Refactor payload length calculation Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 04/13] perf arm-spe: Fix packet length handling Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 05/13] perf arm-spe: Refactor packet header parsing Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 06/13] perf arm-spe: Refactor address packet handling Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 07/13] perf arm-spe: Refactor context " Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 08/13] perf arm-spe: Refactor counter " Leo Yan
2020-08-17 14:53 ` Leo Yan [this message]
2020-08-17 14:53 ` [PATCH RESEND v1 10/13] perf arm-spe: Detect failure for snprintf() Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 11/13] perf arm-spe: Refactor operation packet handling Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 12/13] perf arm-spe: Add more sub classes for operation packet Leo Yan
2020-08-17 14:53 ` [PATCH RESEND v1 13/13] perf arm-spe: Add support for ARMv8.3-SPE Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200817145348.14461-10-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=Al.Grant@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).