[v6,2/3] MAINTAINERS: Add Purism Librem 5 section to the list
diff mbox series

Message ID 20200821121755.24599-2-martin.kepplinger@puri.sm
State In Next
Commit 76dffe8a91e4a8fd4bd81c9158352437f4b0e504
Headers show
Series
  • [v6,1/3] arm64: dts: Add a device tree for the Librem 5 phone
Related show

Commit Message

Martin Kepplinger Aug. 21, 2020, 12:17 p.m. UTC
Add development information for the devicetree files for hardware
by Purism SPC.

Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Shawn Guo Aug. 30, 2020, 1:15 p.m. UTC | #1
On Fri, Aug 21, 2020 at 02:17:54PM +0200, Martin Kepplinger wrote:
> Add development information for the devicetree files for hardware
> by Purism SPC.
> 
> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>

I decided to drop this patch from my queue, as I took the suggestion
from Joe and sent a patch to have get_maintainer report email address
in the dts file.

Shawn

[1] https://lkml.org/lkml/2020/8/30/118

> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ac79fdbdf8d0..70a09eb3e6d6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14061,6 +14061,13 @@ T:	git git://linuxtv.org/media_tree.git
>  F:	Documentation/admin-guide/media/pulse8-cec.rst
>  F:	drivers/media/cec/usb/pulse8/
>  
> +PURISM LIBREM 5
> +M:	Purism Kernel Team <kernel@puri.sm>
> +S:	Supported
> +B:	https://source.puri.sm/Librem5/linux-next/issues
> +T:	https://source.puri.sm/Librem5/linux-next
> +F:	arch/arm64/boot/dts/freescale/imx8mq-librem5*
> +
>  PVRUSB2 VIDEO4LINUX DRIVER
>  M:	Mike Isely <isely@pobox.com>
>  L:	pvrusb2@isely.net	(subscribers-only)
> -- 
> 2.20.1
>
Joe Perches Aug. 30, 2020, 3:32 p.m. UTC | #2
On Sun, 2020-08-30 at 21:15 +0800, Shawn Guo wrote:
> On Fri, Aug 21, 2020 at 02:17:54PM +0200, Martin Kepplinger wrote:
> > Add development information for the devicetree files for hardware
> > by Purism SPC.
> > 
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> 
> I decided to drop this patch from my queue, as I took the suggestion
> from Joe and sent a patch to have get_maintainer report email address
> in the dts file.

It's OK to find maintainers in files, but what about the
B: bug reporting and T: source code repository location lines,

Those seem useful.

> > diff --git a/MAINTAINERS b/MAINTAINERS
[]
> > @@ -14061,6 +14061,13 @@ T:	git git://linuxtv.org/media_tree.git
> >  F:	Documentation/admin-guide/media/pulse8-cec.rst
> >  F:	drivers/media/cec/usb/pulse8/
> >  
> > +PURISM LIBREM 5
> > +M:	Purism Kernel Team <kernel@puri.sm>

People feel like their mails go into a void when no
responses happen after sending to nameless addresses.

It's better to have a named individual as a maintainer
rather than an unspecified exploder address.

It's OK to have both, but just the exploder doesn't
really have that much value as it's faceless.

> > +S:	Supported
> > +B:	https://source.puri.sm/Librem5/linux-next/issues
> > +T:	https://source.puri.sm/Librem5/linux-next

This T: line should be something else.

Perhaps
W;	https://source.puri.sm/Librem5/linux-next
T:	git https://source.puri.sm/Librem5/linux-next.git

> > +F:	arch/arm64/boot/dts/freescale/imx8mq-librem5*
Shawn Guo Aug. 31, 2020, 1:19 a.m. UTC | #3
On Sun, Aug 30, 2020 at 08:32:01AM -0700, Joe Perches wrote:
> On Sun, 2020-08-30 at 21:15 +0800, Shawn Guo wrote:
> > On Fri, Aug 21, 2020 at 02:17:54PM +0200, Martin Kepplinger wrote:
> > > Add development information for the devicetree files for hardware
> > > by Purism SPC.
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > 
> > I decided to drop this patch from my queue, as I took the suggestion
> > from Joe and sent a patch to have get_maintainer report email address
> > in the dts file.
> 
> It's OK to find maintainers in files, but what about the
> B: bug reporting and T: source code repository location lines,
> 
> Those seem useful.

Hmm, I doubt they are practically useful for just a number of dts files.
They are more used for out-of-tree Librem5 kernel drivers, I guess.

Shawn

> 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> []
> > > @@ -14061,6 +14061,13 @@ T:	git git://linuxtv.org/media_tree.git
> > >  F:	Documentation/admin-guide/media/pulse8-cec.rst
> > >  F:	drivers/media/cec/usb/pulse8/
> > >  
> > > +PURISM LIBREM 5
> > > +M:	Purism Kernel Team <kernel@puri.sm>
> 
> People feel like their mails go into a void when no
> responses happen after sending to nameless addresses.
> 
> It's better to have a named individual as a maintainer
> rather than an unspecified exploder address.
> 
> It's OK to have both, but just the exploder doesn't
> really have that much value as it's faceless.
> 
> > > +S:	Supported
> > > +B:	https://source.puri.sm/Librem5/linux-next/issues
> > > +T:	https://source.puri.sm/Librem5/linux-next
> 
> This T: line should be something else.
> 
> Perhaps
> W;	https://source.puri.sm/Librem5/linux-next
> T:	git https://source.puri.sm/Librem5/linux-next.git
> 
> > > +F:	arch/arm64/boot/dts/freescale/imx8mq-librem5*
> 
>
Krzysztof Kozlowski Sept. 30, 2020, 10:50 a.m. UTC | #4
On Sun, 30 Aug 2020 at 15:15, Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Fri, Aug 21, 2020 at 02:17:54PM +0200, Martin Kepplinger wrote:
> > Add development information for the devicetree files for hardware
> > by Purism SPC.
> >
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
>
> I decided to drop this patch from my queue, as I took the suggestion
> from Joe and sent a patch to have get_maintainer report email address
> in the dts file.
>
> Shawn
>
> [1] https://lkml.org/lkml/2020/8/30/118

Shawn, Joe,

Cool idea! Multiple times I needed review/testing for individual
boards and this should be faster than going through git history.

Could you tell me how this is supposed to work for DTS/DTSI files? It
seems it ignores the comments, so usual copyright notice does not have
an effect. Where to put the address?

Best regards,
Krzysztof
Joe Perches Sept. 30, 2020, 3:30 p.m. UTC | #5
On Wed, 2020-09-30 at 12:50 +0200, Krzysztof Kozlowski wrote:
> On Sun, 30 Aug 2020 at 15:15, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Fri, Aug 21, 2020 at 02:17:54PM +0200, Martin Kepplinger wrote:
> > > Add development information for the devicetree files for hardware
> > > by Purism SPC.
> > > 
> > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > 
> > I decided to drop this patch from my queue, as I took the suggestion
> > from Joe and sent a patch to have get_maintainer report email address
> > in the dts file.
> > 
> > Shawn
> > 
> > [1] https://lkml.org/lkml/2020/8/30/118
> 
> Shawn, Joe,
> 
> Cool idea! Multiple times I needed review/testing for individual
> boards and this should be faster than going through git history.
> 
> Could you tell me how this is supposed to work for DTS/DTSI files? It
> seems it ignores the comments, so usual copyright notice does not have
> an effect. Where to put the address?

The get_maintainer.pl script reads an existing file and
looks for whatever appears to be an email address.

It does not ignore comments.

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index ac79fdbdf8d0..70a09eb3e6d6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -14061,6 +14061,13 @@  T:	git git://linuxtv.org/media_tree.git
 F:	Documentation/admin-guide/media/pulse8-cec.rst
 F:	drivers/media/cec/usb/pulse8/
 
+PURISM LIBREM 5
+M:	Purism Kernel Team <kernel@puri.sm>
+S:	Supported
+B:	https://source.puri.sm/Librem5/linux-next/issues
+T:	https://source.puri.sm/Librem5/linux-next
+F:	arch/arm64/boot/dts/freescale/imx8mq-librem5*
+
 PVRUSB2 VIDEO4LINUX DRIVER
 M:	Mike Isely <isely@pobox.com>
 L:	pvrusb2@isely.net	(subscribers-only)