MAINTAINERS: Add entry for HPE Superdome Flex (UV) maintainers
diff mbox series

Message ID 20200821154848.GI7871@localhost.localdomain
State Superseded
Headers show
Series
  • MAINTAINERS: Add entry for HPE Superdome Flex (UV) maintainers
Related show

Commit Message

Steve Wahl Aug. 21, 2020, 3:48 p.m. UTC
Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
---
 MAINTAINERS | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Rob Herring Aug. 21, 2020, 4:45 p.m. UTC | #1
+Joe Perches

On Fri, Aug 21, 2020 at 9:48 AM Steve Wahl <steve.wahl@hpe.com> wrote:
>
>
> Signed-off-by: Steve Wahl <steve.wahl@hpe.com>

get_maintainers.pl doesn't work on MAINTAINERS. You need to send this
to the maintainers of the files listed in the entry below. Looks like
that would be the x86 maintainers.


What did Mauro, David and I do to become MAINTAINERS maintainers?

Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
(commit_signer:127/806=16%,authored:80/806=10%)
Rob Herring <robh@kernel.org> (commit_signer:103/806=13%)
"David S. Miller" <davem@davemloft.net> (commit_signer:99/806=12%)
linux-kernel@vger.kernel.org (open list)


Can we make --no-git-fallback the default? It's useful for
informational purposes, but never for who to email patches to. Having
no output would be better, then submitters have to think about where
to send patches.

What ever happened to splitting up MAINTAINERS to subdirectories? That
would help routing MAINTAINERS changes to the right maintainers.

Rob


> ---
>  MAINTAINERS | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index deaafb617361..4c2143d8ae45 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18874,6 +18874,15 @@ S:     Maintained
>  T:     git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
>  F:     arch/x86/platform
>
> +X86 PLATFORM UV HPE SUPERDOME FLEX
> +M:     Steve Wahl <steve.wahl@hpe.com>
> +R:     Dimitri Sivanich <dimitri.sivanich@hpe.com>
> +R:     Russ Anderson <russ.anderson@hpe.com>
> +S:     Supported
> +F:     arch/x86/include/asm/uv/
> +F:     arch/x86/kernel/apic/x2apic_uv_x.c
> +F:     arch/x86/platform/uv/
> +
>  X86 VDSO
>  M:     Andy Lutomirski <luto@kernel.org>
>  L:     linux-kernel@vger.kernel.org
> --
> 2.12.3
>
Joe Perches Aug. 21, 2020, 5:05 p.m. UTC | #2
On Fri, 2020-08-21 at 10:45 -0600, Rob Herring wrote:
> +Joe Perches
> 
> On Fri, Aug 21, 2020 at 9:48 AM Steve Wahl <steve.wahl@hpe.com> wrote:
> > 
> > Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
> 
> get_maintainers.pl doesn't work on MAINTAINERS. You need to send this
> to the maintainers of the files listed in the entry below. Looks like
> that would be the x86 maintainers.
> 
> 
> What did Mauro, David and I do to become MAINTAINERS maintainers?
> 
> Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> (commit_signer:127/806=16%,authored:80/806=10%)
> Rob Herring <robh@kernel.org> (commit_signer:103/806=13%)
> "David S. Miller" <davem@davemloft.net> (commit_signer:99/806=12%)
> linux-kernel@vger.kernel.org (open list)
> 
> 
> Can we make --no-git-fallback the default? It's useful for
> informational purposes, but never for who to email patches to. Having
> no output would be better, then submitters have to think about where
> to send patches.

Doubtful that improves things.  At least the --git-fallback option
shows who modified or got patches accepted to files that are
nominally unmaintained.  It also shows the upstream path for those
files via Signed-off-by: lines so I think --git-fallback is generally
a good mechanism and control flag for directly unmaintained files.

> What ever happened to splitting up MAINTAINERS to subdirectories? That
> would help routing MAINTAINERS changes to the right maintainers.

Splitting MAINTAINERS into subdirectories would do nothing
to route patches.  It would just be convenience to reduce
the total number of changes to a single file.

Those large number of changes to the single MAINTAINERS file
very rarely have any conflicts either, so it wouldn't really
change the overall number of changes to MAINTAINERS entries
spread around the tree.

You are be welcome to try to split the file and get Linus to
accept it.  I gave it a go.  Try yourself.

https://lore.kernel.org/patchwork/patch/817857/
Rob Herring Aug. 21, 2020, 6:17 p.m. UTC | #3
On Fri, Aug 21, 2020 at 11:05 AM Joe Perches <joe@perches.com> wrote:
>
> On Fri, 2020-08-21 at 10:45 -0600, Rob Herring wrote:
> > +Joe Perches
> >
> > On Fri, Aug 21, 2020 at 9:48 AM Steve Wahl <steve.wahl@hpe.com> wrote:
> > >
> > > Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
> >
> > get_maintainers.pl doesn't work on MAINTAINERS. You need to send this
> > to the maintainers of the files listed in the entry below. Looks like
> > that would be the x86 maintainers.
> >
> >
> > What did Mauro, David and I do to become MAINTAINERS maintainers?
> >
> > Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
> > (commit_signer:127/806=16%,authored:80/806=10%)
> > Rob Herring <robh@kernel.org> (commit_signer:103/806=13%)
> > "David S. Miller" <davem@davemloft.net> (commit_signer:99/806=12%)
> > linux-kernel@vger.kernel.org (open list)
> >
> >
> > Can we make --no-git-fallback the default? It's useful for
> > informational purposes, but never for who to email patches to. Having
> > no output would be better, then submitters have to think about where
> > to send patches.
>
> Doubtful that improves things.  At least the --git-fallback option
> shows who modified or got patches accepted to files that are
> nominally unmaintained.  It also shows the upstream path for those
> files via Signed-off-by: lines so I think --git-fallback is generally
> a good mechanism and control flag for directly unmaintained files.
>
> > What ever happened to splitting up MAINTAINERS to subdirectories? That
> > would help routing MAINTAINERS changes to the right maintainers.
>
> Splitting MAINTAINERS into subdirectories would do nothing
> to route patches.  It would just be convenience to reduce
> the total number of changes to a single file.

In general no, but for MAINTAINERS changes it would. Let's say I add
an entry for Documentation/devicetree/foo-bar.txt. With a per
subsystem/path MAINTAINERS file in
Documentation/devicetree/MAINTAINERS, you'd add an entry there and run
get_maintainer.pl:

$ touch Documentation/devicetree/MAINTAINERS
$ scripts/get_maintainer.pl -f Documentation/devicetree/MAINTAINERS
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED
DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)

> Those large number of changes to the single MAINTAINERS file
> very rarely have any conflicts either, so it wouldn't really
> change the overall number of changes to MAINTAINERS entries
> spread around the tree.
>
> You are be welcome to try to split the file and get Linus to
> accept it.  I gave it a go.  Try yourself.
>
> https://lore.kernel.org/patchwork/patch/817857/

Yes, I remember that. He didn't seem totally opposed to it which is why I asked.

I have another reason for wanting the split. I want to generate a
MAINTAINERS file from the DT schema files. We have the data there and
it's checked automatically. I don't care to either continually tell
folks to add a MAINTAINERS entry or tell them to run checkpatch.pl to
tell them that. But if the infrastructure got merged, would that
already work?

Rob
Joe Perches Aug. 21, 2020, 6:35 p.m. UTC | #4
On Fri, 2020-08-21 at 12:17 -0600, Rob Herring wrote:
> I have another reason for wanting the split. I want to generate a
> MAINTAINERS file from the DT schema files. We have the data there and
> it's checked automatically. I don't care to either continually tell
> folks to add a MAINTAINERS entry or tell them to run checkpatch.pl to
> tell them that. But if the infrastructure got merged, would that
> already work?

It already gets addresses from yaml files.
The same could be done for dts/dtsi files.

Last month I proposed:

https://lore.kernel.org/linux-arm-kernel/da52724655ff2161add7fb27fea8fc673028b9fc.camel@perches.com/
Steve Wahl Aug. 24, 2020, 2:45 p.m. UTC | #5
Added Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, and x86.kernel.org, after being told that
get_maintainers.pl doesn't work on MAINTAINERS.

Thanks,

Steve Wahl, HPE

On Fri, Aug 21, 2020 at 10:48:49AM -0500, Steve Wahl wrote:
> 
> Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
> ---
>  MAINTAINERS | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index deaafb617361..4c2143d8ae45 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18874,6 +18874,15 @@ S:	Maintained
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
>  F:	arch/x86/platform
>  
> +X86 PLATFORM UV HPE SUPERDOME FLEX
> +M:	Steve Wahl <steve.wahl@hpe.com>
> +R:	Dimitri Sivanich <dimitri.sivanich@hpe.com>
> +R:	Russ Anderson <russ.anderson@hpe.com>
> +S:	Supported
> +F:	arch/x86/include/asm/uv/
> +F:	arch/x86/kernel/apic/x2apic_uv_x.c
> +F:	arch/x86/platform/uv/
> +
>  X86 VDSO
>  M:	Andy Lutomirski <luto@kernel.org>
>  L:	linux-kernel@vger.kernel.org
> -- 
> 2.12.3
>
Borislav Petkov Aug. 24, 2020, 3:36 p.m. UTC | #6
On Mon, Aug 24, 2020 at 09:45:23AM -0500, Steve Wahl wrote:
> Added Darren Hart, Andy Shevchenko, Thomas Gleixner, Ingo Molnar,
> Borislav Petkov, and x86.kernel.org, after being told that
> get_maintainers.pl doesn't work on MAINTAINERS.
> 
> Thanks,
> 
> Steve Wahl, HPE
> 
> On Fri, Aug 21, 2020 at 10:48:49AM -0500, Steve Wahl wrote:

I could use a sentence here as a commit message, even if it repeats the
subject line.

> > Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
> > ---
> >  MAINTAINERS | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index deaafb617361..4c2143d8ae45 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18874,6 +18874,15 @@ S:	Maintained
> >  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
> >  F:	arch/x86/platform
> >  
> > +X86 PLATFORM UV HPE SUPERDOME FLEX
> > +M:	Steve Wahl <steve.wahl@hpe.com>
> > +R:	Dimitri Sivanich <dimitri.sivanich@hpe.com>
> > +R:	Russ Anderson <russ.anderson@hpe.com>
> > +S:	Supported
> > +F:	arch/x86/include/asm/uv/
> > +F:	arch/x86/kernel/apic/x2apic_uv_x.c
> > +F:	arch/x86/platform/uv/
> > +
> >  X86 VDSO
> >  M:	Andy Lutomirski <luto@kernel.org>
> >  L:	linux-kernel@vger.kernel.org
> > -- 

Looks ok to me, otherwise.

Patch
diff mbox series

diff --git a/MAINTAINERS b/MAINTAINERS
index deaafb617361..4c2143d8ae45 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18874,6 +18874,15 @@  S:	Maintained
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/core
 F:	arch/x86/platform
 
+X86 PLATFORM UV HPE SUPERDOME FLEX
+M:	Steve Wahl <steve.wahl@hpe.com>
+R:	Dimitri Sivanich <dimitri.sivanich@hpe.com>
+R:	Russ Anderson <russ.anderson@hpe.com>
+S:	Supported
+F:	arch/x86/include/asm/uv/
+F:	arch/x86/kernel/apic/x2apic_uv_x.c
+F:	arch/x86/platform/uv/
+
 X86 VDSO
 M:	Andy Lutomirski <luto@kernel.org>
 L:	linux-kernel@vger.kernel.org