From: Denis Efremov <efremov@linux.com>
To: linux-crypto@vger.kernel.org
Cc: Denis Efremov <efremov@linux.com>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/4] crypto: sun8i-ce - use kfree_sensitive()
Date: Thu, 27 Aug 2020 09:44:01 +0300 [thread overview]
Message-ID: <20200827064402.7130-4-efremov@linux.com> (raw)
In-Reply-To: <20200827064402.7130-1-efremov@linux.com>
Use kfree_sensitive() instead of open-coding it.
Signed-off-by: Denis Efremov <efremov@linux.com>
---
.../crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
index b4d5fea27d20..f996dc3d7dcc 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c
@@ -366,10 +366,7 @@ void sun8i_ce_cipher_exit(struct crypto_tfm *tfm)
{
struct sun8i_cipher_tfm_ctx *op = crypto_tfm_ctx(tfm);
- if (op->key) {
- memzero_explicit(op->key, op->keylen);
- kfree(op->key);
- }
+ kfree_sensitive(op->key);
crypto_free_skcipher(op->fallback_tfm);
pm_runtime_put_sync_suspend(op->ce->dev);
}
@@ -391,10 +388,7 @@ int sun8i_ce_aes_setkey(struct crypto_skcipher *tfm, const u8 *key,
dev_dbg(ce->dev, "ERROR: Invalid keylen %u\n", keylen);
return -EINVAL;
}
- if (op->key) {
- memzero_explicit(op->key, op->keylen);
- kfree(op->key);
- }
+ kfree_sensitive(op->key);
op->keylen = keylen;
op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
if (!op->key)
@@ -416,10 +410,7 @@ int sun8i_ce_des3_setkey(struct crypto_skcipher *tfm, const u8 *key,
if (err)
return err;
- if (op->key) {
- memzero_explicit(op->key, op->keylen);
- kfree(op->key);
- }
+ kfree_sensitive(op->key);
op->keylen = keylen;
op->key = kmemdup(key, keylen, GFP_KERNEL | GFP_DMA);
if (!op->key)
--
2.26.2
next prev parent reply other threads:[~2020-08-27 6:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 6:43 [PATCH v2 0/4] crypto: use kfree_sensitive() Denis Efremov
2020-08-27 6:43 ` [PATCH v2 1/4] crypto: inside-secure - " Denis Efremov
2020-08-27 14:52 ` Corentin Labbe
2020-09-02 9:02 ` Antoine Tenart
2020-09-02 13:10 ` Van Leeuwen, Pascal
2020-09-04 8:55 ` Denis Efremov
2020-09-04 9:44 ` Van Leeuwen, Pascal
2020-08-27 6:44 ` [PATCH v2 2/4] crypto: amlogic " Denis Efremov
2020-08-27 14:50 ` Corentin Labbe
2020-08-27 6:44 ` Denis Efremov [this message]
2020-08-27 14:40 ` [PATCH v2 3/4] crypto: sun8i-ce " Corentin Labbe
2020-08-27 6:44 ` [PATCH v2 4/4] crypto: sun8i-ss " Denis Efremov
2020-08-27 14:41 ` Corentin Labbe
2020-09-04 8:28 ` [PATCH v2 0/4] crypto: " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200827064402.7130-4-efremov@linux.com \
--to=efremov@linux.com \
--cc=clabbe.montjoie@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).