From: Wei Yang <richard.weiyang@linux.alibaba.com>
To: mike.kravetz@oracle.com, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, bhe@redhat.com,
Wei Yang <richard.weiyang@linux.alibaba.com>
Subject: [Patch v4 1/7] mm/hugetlb: not necessary to coalesce regions recursively
Date: Tue, 1 Sep 2020 09:46:30 +0800 [thread overview]
Message-ID: <20200901014636.29737-2-richard.weiyang@linux.alibaba.com> (raw)
In-Reply-To: <20200901014636.29737-1-richard.weiyang@linux.alibaba.com>
Per my understanding, we keep the regions ordered and would always
coalesce regions properly. So the task to keep this property is just
to coalesce its neighbour.
Let's simplify this.
Signed-off-by: Wei Yang <richard.weiyang@linux.alibaba.com>
Reviewed-by: Baoquan He <bhe@redhat.com>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
---
mm/hugetlb.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index a301c2d672bf..db6af2654f12 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -309,8 +309,7 @@ static void coalesce_file_region(struct resv_map *resv, struct file_region *rg)
list_del(&rg->link);
kfree(rg);
- coalesce_file_region(resv, prg);
- return;
+ rg = prg;
}
nrg = list_next_entry(rg, link);
@@ -320,9 +319,6 @@ static void coalesce_file_region(struct resv_map *resv, struct file_region *rg)
list_del(&rg->link);
kfree(rg);
-
- coalesce_file_region(resv, nrg);
- return;
}
}
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2020-09-01 1:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 1:46 [Patch v4 0/7] mm/hugetlb: code refine and simplification Wei Yang
2020-09-01 1:46 ` Wei Yang [this message]
2020-09-01 1:46 ` [Patch v4 2/7] mm/hugetlb: remove VM_BUG_ON(!nrg) in get_file_region_entry_from_cache() Wei Yang
2020-09-01 1:46 ` [Patch v4 3/7] mm/hugetlb: use list_splice to merge two list at once Wei Yang
2020-09-01 1:46 ` [Patch v4 4/7] mm/hugetlb: count file_region to be added when regions_needed != NULL Wei Yang
2020-09-01 1:46 ` [Patch v4 5/7] mm/hugetlb: a page from buddy is not on any list Wei Yang
2020-09-02 10:49 ` Vlastimil Babka
2020-09-02 17:25 ` Mike Kravetz
2020-09-02 17:56 ` Vlastimil Babka
2020-09-01 1:46 ` [Patch v4 6/7] mm/hugetlb: narrow the hugetlb_lock protection area during preparing huge page Wei Yang
2020-09-01 1:46 ` [Patch v4 7/7] mm/hugetlb: take the free hpage during the iteration directly Wei Yang
2020-09-01 21:05 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901014636.29737-2-richard.weiyang@linux.alibaba.com \
--to=richard.weiyang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).