From: "tip-bot2 for Kees Cook" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Kees Cook <keescook@chromium.org>, Ingo Molnar <mingo@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>, x86 <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: [tip: core/build] arm/build: Warn on orphan section placement
Date: Mon, 07 Sep 2020 06:05:51 -0000 [thread overview]
Message-ID: <159945875149.20229.4351707198821263152.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20200902025347.2504702-3-keescook@chromium.org>
The following commit has been merged into the core/build branch of tip:
Commit-ID: 5a17850e251a55bba6d65aefbfeacfa9888cd2cd
Gitweb: https://git.kernel.org/tip/5a17850e251a55bba6d65aefbfeacfa9888cd2cd
Author: Kees Cook <keescook@chromium.org>
AuthorDate: Tue, 01 Sep 2020 19:53:44 -07:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Thu, 03 Sep 2020 10:28:35 +02:00
arm/build: Warn on orphan section placement
We don't want to depend on the linker's orphan section placement
heuristics as these can vary between linkers, and may change between
versions. All sections need to be explicitly handled in the linker
script.
Specifically, this would have made a recently fixed bug very obvious:
ld: warning: orphan section `.fixup' from `arch/arm/lib/copy_from_user.o' being placed in section `.fixup'
With all sections handled, enable orphan section warning.
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Link: https://lore.kernel.org/r/20200902025347.2504702-3-keescook@chromium.org
---
arch/arm/Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 4e87735..e589da3 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -16,6 +16,10 @@ LDFLAGS_vmlinux += --be8
KBUILD_LDFLAGS_MODULE += --be8
endif
+# We never want expected sections to be placed heuristically by the
+# linker. All sections should be explicitly named in the linker script.
+LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn)
+
ifeq ($(CONFIG_ARM_MODULE_PLTS),y)
KBUILD_LDS_MODULE += $(srctree)/arch/arm/kernel/module.lds
endif
next prev parent reply other threads:[~2020-09-07 6:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 2:53 [PATCH v7 0/5] Warn on orphan section placement Kees Cook
2020-09-02 2:53 ` [PATCH v7 1/5] arm64/build: " Kees Cook
2020-09-07 6:05 ` [tip: core/build] " tip-bot2 for Kees Cook
2020-09-02 2:53 ` [PATCH v7 2/5] arm/build: " Kees Cook
2020-09-07 6:05 ` tip-bot2 for Kees Cook [this message]
2020-09-02 2:53 ` [PATCH v7 3/5] arm/boot: " Kees Cook
2020-09-07 6:05 ` [tip: core/build] " tip-bot2 for Kees Cook
2020-09-02 2:53 ` [PATCH v7 4/5] x86/build: " Kees Cook
2020-09-05 22:48 ` Arvind Sankar
2020-09-08 20:17 ` Arvind Sankar
2020-09-07 6:05 ` [tip: core/build] " tip-bot2 for Kees Cook
2020-09-02 2:53 ` [PATCH v7 5/5] x86/boot/compressed: " Kees Cook
2020-09-07 6:05 ` [tip: core/build] " tip-bot2 for Kees Cook
2020-09-02 19:04 ` [PATCH v7 0/5] " Nick Desaulniers
2020-09-04 5:58 ` Ingo Molnar
2020-09-04 18:20 ` Kees Cook
2020-09-06 7:24 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159945875149.20229.4351707198821263152.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ndesaulniers@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).